Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 284008: Fix sync bug where notifications were being sent for unsuccessful commit atte... (Closed)

Created:
11 years, 2 months ago by chron_chromium.org
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, tim (not reviewing), idana
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Fix sync bug where notifications were being sent for unsuccessful commit attempts. BUG=24996 TEST=Manually tested Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29357

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/sync/engine/syncapi.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_session.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
chron_chromium.org
11 years, 2 months ago (2009-10-16 07:50:50 UTC) #1
ncarter (slow)
11 years, 2 months ago (2009-10-16 07:58:40 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698