Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/sync/engine/syncapi.cc

Issue 284008: Fix sync bug where notifications were being sent for unsuccessful commit atte... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/engine/syncer_session.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/syncapi.cc
===================================================================
--- chrome/browser/sync/engine/syncapi.cc (revision 29293)
+++ chrome/browser/sync/engine/syncapi.cc (working copy)
@@ -1400,8 +1400,10 @@
}
// TODO(chron): Consider changing this back to track HasMoreToSync
- // Only notify peers if a commit has occurred and change the bookmark model.
- if (event.last_session && event.last_session->items_committed()) {
+ // Only notify peers if a successful commit has occurred.
+ if (event.last_session && event.last_session->HadSuccessfulCommits()) {
+ // We use a member variable here because talk may not have connected yet.
+ // The notification must be stored until it can be sent.
notification_pending_ = true;
}
« no previous file with comments | « no previous file | chrome/browser/sync/engine/syncer_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698