Fix sync bug where notifications were being sent for unsuccessful commit atte...

chrome/browser/sync/engine/syncapi.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/syncapi.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 1382 matching lines @@
   // the server, but we'll get them on a subsequent sync.
   //
   // Notifications are sent at the end of every sync cycle, regardless of
   // whether we should sync again.
   if (event.what_happened == SyncerEvent::SYNC_CYCLE_ENDED) {
     if (!event.last_session->HasMoreToSync()) {
       observer_->OnSyncCycleCompleted();
     }
 
     // TODO(chron): Consider changing this back to track HasMoreToSync
-    // Only notify peers if a commit has occurred and change the bookmark model.
-    if (event.last_session && event.last_session->items_committed()) {
+    // Only notify peers if a successful commit has occurred.
+    if (event.last_session && event.last_session->HadSuccessfulCommits()) {
+      // We use a member variable here because talk may not have connected yet.
+      // The notification must be stored until it can be sent.
       notification_pending_ = true;
     }
 
     // SyncCycles are started by the following events: creation of the syncer,
     // (re)connection to buzz, local changes, peer notifications of updates.
     // Peers will be notified of changes made while there is no buzz connection
     // immediately after a connection has been re-established.
     // the next sync cycle.
     // TODO(brg): Move this to TalkMediatorImpl as a SyncerThread event hook.
     if (notification_pending_ && talk_mediator()) {
@@ skipping 148 matching lines @@
 BaseTransaction::~BaseTransaction() {
   delete lookup_;
 }
 
 UserShare* SyncManager::GetUserShare() const {
   DCHECK(data_->initialized()) << "GetUserShare requires initialization!";
   return data_->GetUserShare();
 }
 
 }  // namespace sync_api