Fix sync bug where notifications were being sent for unsuccessful commit atte...

chrome/browser/sync/engine/syncer_session.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // SyncerSession holds the entire state of a single sync cycle; GetUpdates,
 // Commit, and Conflict Resolution. After said cycle, the Session may contain
 // items that were unable to be processed because of errors.
 //
 // THIS CLASS PROVIDES NO SYNCHRONIZATION GUARANTEES.
 
@@ skipping 135 matching lines @@
   }
 
   void set_commit_ids(const std::vector<syncable::Id>& commit_ids) {
     sync_cycle_state_->set_commit_ids(commit_ids);
   }
 
   bool commit_ids_empty() const {
     return sync_cycle_state_->commit_ids_empty();
   }
 
+  bool HadSuccessfulCommits() const {
+    return sync_process_state_->successful_commits() > 0;
+  }
+
   syncable::WriteTransaction* write_transaction() const {
     return sync_cycle_state_->write_transaction();
   }
 
   bool has_open_write_transaction() const {
     return sync_cycle_state_->has_open_write_transaction();
   }
 
   ClientToServerMessage* commit_message() const {
     return sync_cycle_state_->commit_message();
@@ skipping 188 matching lines @@
   // True if notifications are enabled when this session was created.
   bool notifications_enabled_;
 
   FRIEND_TEST(SyncerTest, TestCommitListOrderingCounterexample);
   DISALLOW_COPY_AND_ASSIGN(SyncerSession);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_ENGINE_SYNCER_SESSION_H_