Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2841913003: [WIP] Initial CallFunctionCallback builtin.

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[WIP] Initial CallFunctionCallback builtin.

Patch Set 1 #

Patch Set 2 : ports. #

Patch Set 3 : ia32 port and x64 fixes. #

Patch Set 4 : Plug it in on ia32. #

Patch Set 5 : Fixes #

Patch Set 6 : Fix ia32. #

Patch Set 7 : Moar Fixes. #

Patch Set 8 : MIPS ports. #

Patch Set 9 : All ports working...? #

Patch Set 10 : Fix wrong register for arm64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1145 lines, -88 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -5 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M src/assembler.h View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
M src/builtins/arm/builtins-arm.cc View 1 2 3 4 5 6 7 8 2 chunks +153 lines, -0 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 2 3 4 5 6 7 8 9 2 chunks +157 lines, -0 lines 0 comments Download
M src/builtins/builtins-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 2 3 4 2 chunks +162 lines, -0 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 2 3 4 5 6 7 8 2 chunks +152 lines, -0 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 2 3 4 5 6 7 8 2 chunks +150 lines, -0 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 2 3 4 5 6 7 8 2 chunks +134 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 6 2 chunks +7 lines, -33 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 5 6 7 8 3 chunks +9 lines, -5 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 4 5 6 7 1 chunk +27 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -7 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 3 4 5 6 7 1 chunk +27 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 2 chunks +7 lines, -33 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (36 generated)
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-25 19:15:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841913003/1
3 years, 8 months ago (2017-04-25 19:15:27 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-25 19:18:57 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/35034) v8_linux_rel_ng on ...
3 years, 8 months ago (2017-04-25 19:18:58 UTC) #4
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 05:10:06 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841913003/40001
3 years, 8 months ago (2017-04-26 05:10:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 05:14:25 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/20673) v8_linux_mips64el_compile_rel on ...
3 years, 8 months ago (2017-04-26 05:14:26 UTC) #8
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 05:31:31 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841913003/40002
3 years, 8 months ago (2017-04-26 05:31:35 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 05:34:35 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/20674) v8_linux_arm_rel_ng on ...
3 years, 8 months ago (2017-04-26 05:34:36 UTC) #12
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 06:37:29 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841913003/70001
3 years, 8 months ago (2017-04-26 06:37:36 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 06:41:26 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/35053) v8_linux_mips64el_compile_rel on ...
3 years, 8 months ago (2017-04-26 06:41:26 UTC) #16
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 06:42:36 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841913003/90001
3 years, 8 months ago (2017-04-26 06:42:47 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 06:44:56 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/35054) v8_linux_mipsel_compile_rel on ...
3 years, 8 months ago (2017-04-26 06:44:57 UTC) #20
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 06:52:53 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841913003/110001
3 years, 8 months ago (2017-04-26 06:52:56 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 06:55:46 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/20678) v8_linux_mips64el_compile_rel on ...
3 years, 8 months ago (2017-04-26 06:55:47 UTC) #24
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 08:05:15 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841913003/130001
3 years, 8 months ago (2017-04-26 08:05:21 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 08:10:11 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/33352)
3 years, 8 months ago (2017-04-26 08:10:11 UTC) #28
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 08:46:30 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841913003/150001
3 years, 8 months ago (2017-04-26 08:46:32 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 09:45:44 UTC) #31
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/20682) v8_linux_arm64_rel_ng_triggered on ...
3 years, 8 months ago (2017-04-26 09:45:45 UTC) #32
Benedikt Meurer
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 10:30:56 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841913003/170001
3 years, 8 months ago (2017-04-26 10:31:07 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 10:55:21 UTC) #35
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 10:55:22 UTC) #36 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698