Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2839903004: Merge 3071: Postpone enabling CSS line-height-step on stable (Closed)

Created:
3 years, 7 months ago by kojii
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge 3071: Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property will be used more widely by East Asians, but it will still take time to grow. Delaying by a few months will not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=714956, 586413 Review-Url: https://codereview.chromium.org/2833323002 Cr-Commit-Position: refs/heads/master@{#466910} (cherry picked from commit 0c9c589259849ee69875a9d173a98f5fb2c0fde6) Review-Url: https://codereview.chromium.org/2839903004 . Cr-Commit-Position: refs/branch-heads/3071@{#233} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1ef31d96fb858f9b220c9292401533cbb301d9c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
3 years, 7 months ago (2017-04-26 18:54:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ef31d96fb858f9b220c9292401533cbb301d9c7.

Powered by Google App Engine
This is Rietveld 408576698