Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2833323002:
Postpone enabling CSS line-height-step on stable (Closed)
DescriptionPostpone enabling CSS line-height-step on stable
This patch postpones r462778[1] that enabled CSS line-height-step on
stable.
While we do not see web-compat risks, we heard that enabling on stable
gives a pressure to discussions, and that delaying can make it easier.
We expect this feature to grow only slowly. The previous similar feature
was at 0.007% UMA. I hope this property will be used more widely by East
Asians, but it will still take time to grow. Delaying by a few months
will not make much differences in the value of the feature.
[1] https://codereview.chromium.org/2797973005
BUG=714956
Review-Url: https://codereview.chromium.org/2833323002
Cr-Commit-Position: refs/heads/master@{#466910}
Committed: https://chromium.googlesource.com/chromium/src/+/0c9c589259849ee69875a9d173a98f5fb2c0fde6
Patch Set 1 #
Messages
Total messages: 25 (18 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== lhsdis BUG= ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778 to enable CSS line-height-step on stable. While we do not see web-compat risks, we heard concerns that enabling on stable gives a pressure to discussions, and that delaying would feel them easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. Delaying by a few months is unlikely to reduce the feature values at all. BUG=586413 ==========
Description was changed from ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778 to enable CSS line-height-step on stable. While we do not see web-compat risks, we heard concerns that enabling on stable gives a pressure to discussions, and that delaying would feel them easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. Delaying by a few months is unlikely to reduce the feature values at all. BUG=586413 ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard concerns that enabling on stable gives a pressure to discussions, and that delaying would feel them easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. Delaying by a few months is unlikely to reduce the feature values at all. [1] https://codereview.chromium.org/2797973005 BUG=586413 ==========
Description was changed from ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard concerns that enabling on stable gives a pressure to discussions, and that delaying would feel them easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. Delaying by a few months is unlikely to reduce the feature values at all. [1] https://codereview.chromium.org/2797973005 BUG=586413 ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard concerns that enabling on stable gives a pressure to discussions, and that delaying would feel them easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. Delaying by a few months is unlikely to reduce the feature values at all. [1] https://codereview.chromium.org/2797973005 BUG=586413 ==========
Description was changed from ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard concerns that enabling on stable gives a pressure to discussions, and that delaying would feel them easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. Delaying by a few months is unlikely to reduce the feature values at all. [1] https://codereview.chromium.org/2797973005 BUG=586413 ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. Delaying by a few months is unlikely to reduce the feature values at all. [1] https://codereview.chromium.org/2797973005 BUG=586413 ==========
kojii@chromium.org changed reviewers: + eae@chromium.org, rbyers@chromium.org
As we discussed last week. I don't see web-compat risks after F2F discussions, but it looked like a bit more time was preferred.
OK LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. Delaying by a few months is unlikely to reduce the feature values at all. [1] https://codereview.chromium.org/2797973005 BUG=586413 ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. I hope this property to be used more widely by adopting needs from East Asians, but the growth is likely to be slow. Delaying by a few months is unlikely to reduce the feature values at all. [1] https://codereview.chromium.org/2797973005 BUG=586413 ==========
Description was changed from ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly, as the previous similar feature was at 0.007% UMA. I hope this property to be used more widely by adopting needs from East Asians, but the growth is likely to be slow. Delaying by a few months is unlikely to reduce the feature values at all. [1] https://codereview.chromium.org/2797973005 BUG=586413 ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property to be used more widely by adopting to East Asians needs, but it will still take time to be used. Delaying by a few months should not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=586413 ==========
Description was changed from ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property to be used more widely by adopting to East Asians needs, but it will still take time to be used. Delaying by a few months should not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=586413 ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property will be used more widely by East Asians, but it will still take time to be used. Delaying by a few months will not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=586413 ==========
Description was changed from ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property will be used more widely by East Asians, but it will still take time to be used. Delaying by a few months will not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=586413 ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property will be used more widely by East Asians, but it will still take time to grow. Delaying by a few months will not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=586413 ==========
kojii@chromium.org changed reviewers: + tkent@chromium.org
tkent@, PTAL for LayoutTests/virtual/stable/webexposed. I talked this to Rick offline last week and he was ok.
lgtm. > BUG=586413 Will you merge this to M59? If so, I recommend to file a new bug for the revert. It makes merge approval easier.
Description was changed from ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property will be used more widely by East Asians, but it will still take time to grow. Delaying by a few months will not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=586413 ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property will be used more widely by East Asians, but it will still take time to grow. Delaying by a few months will not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=714956 ==========
On 2017/04/25 at 01:57:59, tkent wrote: > > BUG=586413 > > Will you merge this to M59? If so, I recommend to file a new bug for the revert. It makes merge approval easier. Thank you for the suggestion, done.
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493086530509640, "parent_rev":
"11d59e51532e90c9178e541f5605f12846a4ebc5", "commit_rev":
"0c9c589259849ee69875a9d173a98f5fb2c0fde6"}
Message was sent while issue was closed.
Description was changed from ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property will be used more widely by East Asians, but it will still take time to grow. Delaying by a few months will not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=714956 ========== to ========== Postpone enabling CSS line-height-step on stable This patch postpones r462778[1] that enabled CSS line-height-step on stable. While we do not see web-compat risks, we heard that enabling on stable gives a pressure to discussions, and that delaying can make it easier. We expect this feature to grow only slowly. The previous similar feature was at 0.007% UMA. I hope this property will be used more widely by East Asians, but it will still take time to grow. Delaying by a few months will not make much differences in the value of the feature. [1] https://codereview.chromium.org/2797973005 BUG=714956 Review-Url: https://codereview.chromium.org/2833323002 Cr-Commit-Position: refs/heads/master@{#466910} Committed: https://chromium.googlesource.com/chromium/src/+/0c9c589259849ee69875a9d173a9... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0c9c589259849ee69875a9d173a9... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
