Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2797973005: Enable CSS line-height-step property on stable (Closed)

Created:
3 years, 8 months ago by kojii
Modified:
3 years, 8 months ago
Reviewers:
tkent, eae
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable CSS line-height-step property on stable This patch enables CSS line-height-step property on stable. Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/z0RI8seNuCs/ATwON9v3FwAJ BUG=586413 Review-Url: https://codereview.chromium.org/2797973005 Cr-Commit-Position: refs/heads/master@{#462778} Committed: https://chromium.googlesource.com/chromium/src/+/347acf86c415243da06f97bdad5861449964b203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
kojii
PTAL.
3 years, 8 months ago (2017-04-06 10:00:59 UTC) #7
eae
LGTM but please update the CL description to link to the Intent to Ship thread.
3 years, 8 months ago (2017-04-06 11:47:57 UTC) #8
kojii
Done, thank you. tkent@, PTAL for LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
3 years, 8 months ago (2017-04-06 12:43:31 UTC) #10
tkent
lgtm
3 years, 8 months ago (2017-04-06 22:31:05 UTC) #11
kojii
Thank you so much for your support here and in intents!!
3 years, 8 months ago (2017-04-07 05:40:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797973005/1
3 years, 8 months ago (2017-04-07 05:41:23 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 05:48:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/347acf86c415243da06f97bdad58...

Powered by Google App Engine
This is Rietveld 408576698