MD Settings: Fix networking config errors

MD Settings: Fix networking config errors

This CL:
* Correctly handles errors from chrome when a guid becomes
  stale.
* Updates EAP properties in the networking_private IDl and
  in onc_spec.md.
* Fixes networking_private_chromeos.cc to not set empty
  proxy values.

BUG=714210, 710238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2839693003
Cr-Commit-Position: refs/heads/master@{#467131}
Committed: https://chromium.googlesource.com/chromium/src/+/382dc5ad70e096a8df3fea9c80e47e372bb04d00

[stevenjb, 2017-04-24 22:28:00]

Description was changed from

==========
MD Settings: Fix networking config errors

This CL:
* Correctly handles errors from chrome when a guid becomes
  stale.
* Updates EAP properties in the networking_private IDl and
  in onc_spec.md.
* Fixes networking_private_chromeos.cc to not set empty
  proxy values.

BUG=714210,710238
==========

to

==========
MD Settings: Fix networking config errors

This CL:
* Correctly handles errors from chrome when a guid becomes
  stale.
* Updates EAP properties in the networking_private IDl and
  in onc_spec.md.
* Fixes networking_private_chromeos.cc to not set empty
  proxy values.

BUG=714210,710238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-24 22:31:11]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org, rdevlin.cronin@chromium.org, tbarzic@chromium.org

[stevenjb, 2017-04-24 22:31:12]

tbarzic: IDL/ONC changes
rdevlin.cronin: IDL + extensions owner
michaelpg: JS

[michaelpg, 2017-04-24 22:47:35]

lgtm

[tbarzic, 2017-04-24 23:32:43]

lgtm

https://codereview.chromium.org/2839693003/diff/1/components/onc/docs/onc_spe...
File components/onc/docs/onc_spec.md (right):

https://codereview.chromium.org/2839693003/diff/1/components/onc/docs/onc_spe...
components/onc/docs/onc_spec.md:1091: **ServerCARef** and **ServerCARefs** must
be unset.
(very minor) nit: imho "must not be set" sounds better than "must be unset", but
up to you

[stevenjb, 2017-04-25 00:00:52]

https://codereview.chromium.org/2839693003/diff/1/components/onc/docs/onc_spe...
File components/onc/docs/onc_spec.md (right):

https://codereview.chromium.org/2839693003/diff/1/components/onc/docs/onc_spe...
components/onc/docs/onc_spec.md:1091: **ServerCARef** and **ServerCARefs** must
be unset.
On 2017/04/24 23:32:43, tbarzic wrote:
> (very minor) nit: imho "must not be set" sounds better than "must be unset",
but
> up to you

I was being consistent with other comments. We can clean this up separately,
because I agree.

[stevenjb, 2017-04-25 00:01:01]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 00:01:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbarzic, 2017-04-25 00:08:36]

https://codereview.chromium.org/2839693003/diff/1/components/onc/docs/onc_spe...
File components/onc/docs/onc_spec.md (right):

https://codereview.chromium.org/2839693003/diff/1/components/onc/docs/onc_spe...
components/onc/docs/onc_spec.md:1091: **ServerCARef** and **ServerCARefs** must
be unset.
On 2017/04/25 00:00:52, stevenjb wrote:
> On 2017/04/24 23:32:43, tbarzic wrote:
> > (very minor) nit: imho "must not be set" sounds better than "must be unset",
> but
> > up to you
> 
> I was being consistent with other comments. We can clean this up separately,
> because I agree.

ok, sgtm

[commit-bot: I haz the power, 2017-04-25 01:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 01:01:07]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-04-25 16:54:25]

Devlin - ping

[Devlin, 2017-04-25 16:58:50]

https://codereview.chromium.org/2839693003/diff/1/extensions/common/api/netwo...
File extensions/common/api/networking_private.idl (right):

https://codereview.chromium.org/2839693003/diff/1/extensions/common/api/netwo...
extensions/common/api/networking_private.idl:237: // fron Shill. TODO(stevenjb):
Fix that in ShillToONCTranslator.
Typo: fron -> from

Note: These become public documents at
developer.chrome.com/extensions/networkingPrivate.  Now, this isn't the end of
the world, because it's a private API, but I'd love to try and minimize the
TODO-style comments we add to these.  Could we put this somewhere else?

https://codereview.chromium.org/2839693003/diff/1/extensions/common/api/netwo...
extensions/common/api/networking_private.idl:238: DOMString? Outer;
Does networking_onc.idl need to be updated?

[stevenjb, 2017-04-25 18:05:15]

PTAL

https://codereview.chromium.org/2839693003/diff/1/extensions/common/api/netwo...
File extensions/common/api/networking_private.idl (right):

https://codereview.chromium.org/2839693003/diff/1/extensions/common/api/netwo...
extensions/common/api/networking_private.idl:237: // fron Shill. TODO(stevenjb):
Fix that in ShillToONCTranslator.
On 2017/04/25 16:58:50, Devlin wrote:
> Typo: fron -> from
> 
> Note: These become public documents at
> developer.chrome.com/extensions/networkingPrivate.  Now, this isn't the end of
> the world, because it's a private API, but I'd love to try and minimize the
> TODO-style comments we add to these.  Could we put this somewhere else?

Thanks for pointing that out. The TODO isn't really necessary, I'll just leave
the rest of the comment. The fix is tricky and not really necessary so may not
happen.

https://codereview.chromium.org/2839693003/diff/1/extensions/common/api/netwo...
extensions/common/api/networking_private.idl:238: DOMString? Outer;
On 2017/04/25 16:58:50, Devlin wrote:
> Does networking_onc.idl need to be updated?

Kind of. It's actually missing the Managed version of these, and has some other
differences with this dictionary, I'm not exactly sure why, and I plan to follow
up on that, but I'll go ahead and at least change its EAPProperties to be
consistent with these changes.

[Devlin, 2017-04-25 19:26:17]

idls lgtm

[stevenjb, 2017-04-25 19:28:44]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-25 19:28:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
tbarzic@chromium.org, michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2839693003/#ps20001
(title: "Feedback")

[commit-bot: I haz the power, 2017-04-25 19:29:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 20:29:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 20:29:56]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[stevenjb, 2017-04-25 21:02:15]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-04-25 21:03:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 22:05:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493154135885060,
"parent_rev": "1931faea0d5ada216fca3c11add153ceaa82ba6d", "commit_rev":
"382dc5ad70e096a8df3fea9c80e47e372bb04d00"}

[commit-bot: I haz the power, 2017-04-25 22:05:38]

Description was changed from

==========
MD Settings: Fix networking config errors

This CL:
* Correctly handles errors from chrome when a guid becomes
  stale.
* Updates EAP properties in the networking_private IDl and
  in onc_spec.md.
* Fixes networking_private_chromeos.cc to not set empty
  proxy values.

BUG=714210,710238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix networking config errors

This CL:
* Correctly handles errors from chrome when a guid becomes
  stale.
* Updates EAP properties in the networking_private IDl and
  in onc_spec.md.
* Fixes networking_private_chromeos.cc to not set empty
  proxy values.

BUG=714210,710238
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2839693003
Cr-Commit-Position: refs/heads/master@{#467131}
Committed:
https://chromium.googlesource.com/chromium/src/+/382dc5ad70e096a8df3fea9c80e4...
==========

[commit-bot: I haz the power, 2017-04-25 22:05:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/382dc5ad70e096a8df3fea9c80e4...