MD Settings: Fix networking config errors

extensions/common/api/networking_private.idl

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The <code>chrome.networkingPrivate</code> API is used for configuring
 // network connections (Cellular, Ethernet, VPN, WiFi or WiMAX). This private
 // API is only valid if called from a browser or app associated with the
 // primary user. See the Open Network Configuration (ONC) documentation for
 // descriptions of properties:
 // <a href="https://code.google.com/p/chromium/codesearch#chromium/src/components/onc/docs/onc_spec.html">
@@ skipping 215 matching lines @@
     ManagedIssuerSubjectPattern? Subject;
   };
 
   dictionary EAPProperties {
     DOMString? AnonymousIdentity;
     CertificatePattern? ClientCertPattern;
     DOMString? ClientCertRef;
     DOMString? ClientCertType;
     DOMString? Identity;
     DOMString? Inner;
-    DOMString Outer;
+    // Outer is required by ONC, but may not be provided when translating
+    // fron Shill. TODO(stevenjb): Fix that in ShillToONCTranslator.

[Devlin, 2017/04/25 16:58:50]

Typo: fron -> from

Note: These become public documents at
developer.chrome.com/extensions/networkingPrivate.  Now, this isn't the end of
the world, because it's a private API, but I'd love to try and minimize the
TODO-style comments we add to these.  Could we put this somewhere else?

[stevenjb, 2017/04/25 18:05:15]

Thanks for pointing that out. The TODO isn't really necessary, I'll just leave
the rest of the comment. The fix is tricky and not really necessary so may not
happen. 

+    DOMString? Outer;

[Devlin, 2017/04/25 16:58:50]

Does networking_onc.idl need to be updated?

[stevenjb, 2017/04/25 18:05:15]

Kind of. It's actually missing the Managed version of these, and has some other
differences with this dictionary, I'm not exactly sure why, and I plan to follow
up on that, but I'll go ahead and at least change its EAPProperties to be
consistent with these changes.

     DOMString? Password;
     boolean? SaveCredentials;
+    DOMString[]? ServerCAPEMs;
     DOMString[]? ServerCARefs;
     boolean? UseProactiveKeyCaching;
     boolean? UseSystemCAs;
   };
 
   dictionary ManagedEAPProperties {
     ManagedDOMString? AnonymousIdentity;
     ManagedCertificatePattern? ClientCertPattern;
     ManagedDOMString? ClientCertRef;
     ManagedDOMString? ClientCertType;
     ManagedDOMString? Identity;
     ManagedDOMString? Inner;
-    ManagedDOMString Outer;
+    // Outer is required by ONC, but may not be provided when translating
+    // fron Shill. TODO(stevenjb): Fix that in ShillToONCTranslator.
+    ManagedDOMString? Outer;
     ManagedDOMString? Password;
     ManagedBoolean? SaveCredentials;
+    ManagedDOMStringList? ServerCAPEMs;
     ManagedDOMStringList? ServerCARefs;
     ManagedBoolean? UseProactiveKeyCaching;
     ManagedBoolean? UseSystemCAs;
   };
 
   dictionary FoundNetworkProperties {
     DOMString Status;
     DOMString NetworkId;
     DOMString Technology;
     DOMString? ShortName;
@@ skipping 818 matching lines @@
     // Fired when the list of devices has changed or any device state properties
     // have changed.
     static void onDeviceStateListChanged();
 
     // Fired when a portal detection for a network completes. Sends the guid of
     // the network and the corresponding captive portal status.
     static void onPortalDetectionCompleted(DOMString networkGuid,
                                            CaptivePortalStatus status);
   };
 };