Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2839693003: MD Settings: Fix networking config errors (Closed)
Patch Set: Feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_subpage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
index 760db46b12bb8dc04ce4cc261f140da8efee0e0e..ef74fd58e9a3f81d343047e79d349016b95633d8 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
@@ -267,12 +267,24 @@ Polymer({
* @private
*/
getPropertiesCallback_: function(properties) {
- this.networkProperties = properties;
+ if (chrome.runtime.lastError) {
+ var message = chrome.runtime.lastError.message;
+ if (message == 'Error.InvalidNetworkGuid') {
+ console.error('Details page: GUID no longer exists: ' + this.guid);
+ } else {
+ console.error(
+ 'Unexpected networkingPrivate.getManagedProperties error: ' +
+ message + ' For: ' + this.guid);
+ }
+ this.close_();
+ return;
+ }
if (!properties) {
- // If |properties| is null, the network is no longer visible, close this.
- console.error('Network no longer exists: ' + this.guid);
+ console.error('No properties for: ' + this.guid);
this.close_();
+ return;
}
+ this.networkProperties = properties;
},
/**
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_subpage.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698