Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2839063004: [Autofill] UKM for suggestions polled field. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index 58ab8d26aa06d64471b9fe76613a5405d877f61c..1a24922b5157330b79386a0fceb932fad12dc023 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -38,6 +38,12 @@ extern const char kUKMIsForCreditCardMetricName[];
extern const char kUKMLocalRecordTypeCountMetricName[];
extern const char kUKMServerRecordTypeCountMetricName[];
+// |UkmEntry| when user polls suggestions. Metrics for field type.
csashi 2017/04/27 18:41:17 Can we not add the metrics to "Suggestions shown"
jiahuiguo 2017/05/24 18:00:00 Done.
+extern const char kUKMPollSuggestionsEntryName[];
+extern const char kUKMHeuristicTypeMetricName[];
+extern const char kUKMHtmlFieldTypeMetricName[];
+extern const char kUKMServerTypeMetricName[];
+
// |UkmEntry| when we show suggestions.
extern const char kUKMSuggestionsShownEntryName[];
@@ -59,9 +65,6 @@ extern const char kUKMRecordTypeMetricName[];
// |UkmEntry| for user editing text field. Metrics contain field's attributes.
extern const char kUKMTextFieldDidChangeEntryName[];
extern const char kUKMFieldTypeGroupMetricName[];
-extern const char kUKMHeuristicTypeMetricName[];
-extern const char kUKMServerTypeMetricName[];
-extern const char kUKMHtmlFieldTypeMetricName[];
extern const char kUKMHtmlFieldModeMetricName[];
extern const char kUKMIsAutofilledMetricName[];
extern const char kUKMIsEmptyMetricName[];
@@ -622,6 +625,7 @@ class AutofillMetrics {
void LogInteractedWithForm(bool is_for_credit_card,
size_t local_record_type_count,
size_t server_record_type_count);
+ void LogPollSuggestions(const AutofillField& field);
void LogSuggestionsShown();
void LogSelectedMaskedServerCard();
void LogDidFillSuggestion(int record_type);
@@ -841,7 +845,8 @@ class AutofillMetrics {
void OnDidInteractWithAutofillableForm();
- void OnDidPollSuggestions(const FormFieldData& field);
+ void OnDidPollSuggestions(const FormFieldData& field,
+ const AutofillField& autofill_field);
void OnDidShowSuggestions();

Powered by Google App Engine
This is Rietveld 408576698