[Autofill] UKM for suggestions polled field.

components/autofill/core/browser/autofill_metrics.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 #include <utility>
@@ skipping 20 matching lines @@
 
 // Each form interaction event has a separate |UkmEntry|.
 
 // The first form event |UkmEntry| contains metrics for metadata that apply
 // to all subsequent events.
 extern const char kUKMInteractedWithFormEntryName[];
 extern const char kUKMIsForCreditCardMetricName[];
 extern const char kUKMLocalRecordTypeCountMetricName[];
 extern const char kUKMServerRecordTypeCountMetricName[];
 
+// |UkmEntry| when user polls suggestions. Metrics for field type.

[csashi, 2017/04/27 18:41:17]

Can we not add the metrics to "Suggestions shown" - poll suggestions seems like
an internal implementation detail that does not directly map to a comprehensible
action - or does it?

[jiahuiguo, 2017/05/24 18:00:00]

Done.

+extern const char kUKMPollSuggestionsEntryName[];
+extern const char kUKMHeuristicTypeMetricName[];
+extern const char kUKMHtmlFieldTypeMetricName[];
+extern const char kUKMServerTypeMetricName[];
+
 // |UkmEntry| when we show suggestions.
 extern const char kUKMSuggestionsShownEntryName[];
 
 // |UkmEntry| when user selects a masked server credit card.
 extern const char kUKMSelectedMaskedServerCardEntryName[];
 
 // Each |UkmEntry|, except the first interaction with the form, has a metric for
 // time elapsed, in milliseconds, since we loaded the form.
 extern const char kUKMMillisecondsSinceFormLoadedMetricName[];
 
 // |FormEvent| for FORM_EVENT_*_SUGGESTION_FILLED in credit card forms include a
 // |CreditCard| |record_type()| to indicate if the suggestion was for a local
 // card, masked server card or full server card. Similarly, address/profile
 // forms include a |AutofillProfile| |record_type()| to indicate if the
 // profile was a local profile or server profile.
 extern const char kUKMSuggestionFilledEntryName[];
 extern const char kUKMRecordTypeMetricName[];
 
 // |UkmEntry| for user editing text field. Metrics contain field's attributes.
 extern const char kUKMTextFieldDidChangeEntryName[];
 extern const char kUKMFieldTypeGroupMetricName[];
-extern const char kUKMHeuristicTypeMetricName[];
-extern const char kUKMServerTypeMetricName[];
-extern const char kUKMHtmlFieldTypeMetricName[];
 extern const char kUKMHtmlFieldModeMetricName[];
 extern const char kUKMIsAutofilledMetricName[];
 extern const char kUKMIsEmptyMetricName[];
 
 // |UkmEntry| for |AutofillFormSubmittedState|.
 extern const char kUKMFormSubmittedEntryName[];
 extern const char kUKMAutofillFormSubmittedStateMetricName[];
 }  // namespace internal
 
 namespace autofill {
@@ skipping 540 matching lines @@
   class FormInteractionsUkmLogger {
    public:
     explicit FormInteractionsUkmLogger(ukm::UkmService* ukm_service);
 
     const GURL& url() const { return url_; }
 
     void OnFormsLoaded(const GURL& url);
     void LogInteractedWithForm(bool is_for_credit_card,
                                size_t local_record_type_count,
                                size_t server_record_type_count);
+    void LogPollSuggestions(const AutofillField& field);
     void LogSuggestionsShown();
     void LogSelectedMaskedServerCard();
     void LogDidFillSuggestion(int record_type);
     void LogTextFieldDidChange(const AutofillField& field);
     void LogFormSubmitted(AutofillFormSubmittedState state);
 
     // We initialize |url_| with the form's URL when we log the first form
     // interaction. Later, we may update |url_| with the |source_url()| for the
     // submitted form.
     void UpdateSourceURL(const GURL& url);
@@ skipping 199 matching lines @@
     inline void set_local_record_type_count(size_t local_record_type_count) {
       local_record_type_count_ = local_record_type_count;
     }
 
     inline void set_is_context_secure(bool is_context_secure) {
       is_context_secure_ = is_context_secure;
     }
 
     void OnDidInteractWithAutofillableForm();
 
-    void OnDidPollSuggestions(const FormFieldData& field);
+    void OnDidPollSuggestions(const FormFieldData& field,
+                              const AutofillField& autofill_field);
 
     void OnDidShowSuggestions();
 
     void OnDidSelectMaskedServerCardSuggestion();
 
     // In case of masked cards, caller must make sure this gets called before
     // the card is upgraded to a full card.
     void OnDidFillSuggestion(const CreditCard& credit_card);
 
     void OnDidFillSuggestion(const AutofillProfile& profile);
@@ skipping 25 matching lines @@
         form_interactions_ukm_logger_;  // Weak reference.
   };
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_