Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2839063004: [Autofill] UKM for suggestions polled field. (Closed)
Patch Set: Address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 6921626a500115c18287ed9fd16677a5b43629e3..fd254893ef4564819664bba537b88c3d007bce60 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -605,7 +605,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
return;
}
if (is_filling_credit_card) {
- suggestions = GetCreditCardSuggestions(field, autofill_field->Type());
+ suggestions = GetCreditCardSuggestions(field, *autofill_field);
} else {
suggestions =
GetProfileSuggestions(*form_structure, field, *autofill_field);
@@ -1863,7 +1863,7 @@ std::vector<Suggestion> AutofillManager::GetProfileSuggestions(
const FormStructure& form,
const FormFieldData& field,
const AutofillField& autofill_field) const {
- address_form_event_logger_->OnDidPollSuggestions(field);
+ address_form_event_logger_->OnDidPollSuggestions(field, autofill_field);
std::vector<ServerFieldType> field_types(form.field_count());
for (size_t i = 0; i < form.field_count(); ++i) {
@@ -1890,14 +1890,14 @@ std::vector<Suggestion> AutofillManager::GetProfileSuggestions(
std::vector<Suggestion> AutofillManager::GetCreditCardSuggestions(
const FormFieldData& field,
- const AutofillType& type) const {
- credit_card_form_event_logger_->OnDidPollSuggestions(field);
+ const AutofillField& autofill_field) const {
+ credit_card_form_event_logger_->OnDidPollSuggestions(field, autofill_field);
// The field value is sanitized before attempting to match it to the user's
// data.
std::vector<Suggestion> suggestions =
personal_data_->GetCreditCardSuggestions(
- type, SanitizeCreditCardFieldValue(field.value));
+ autofill_field.Type(), SanitizeCreditCardFieldValue(field.value));
for (size_t i = 0; i < suggestions.size(); i++) {
suggestions[i].frontend_id =
MakeFrontendID(suggestions[i].backend_id, std::string());

Powered by Google App Engine
This is Rietveld 408576698