[Autofill] UKM for suggestions polled field.

components/autofill/core/browser/autofill_manager.h

Index: components/autofill/core/browser/autofill_manager.h
diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h
index 83915b57441687a54bf9be6268efc5af1f076f3c..9313f11e50e3a71de218c5ddaa0575f7617ed583 100644
--- a/components/autofill/core/browser/autofill_manager.h
+++ b/components/autofill/core/browser/autofill_manager.h
@@ -60,7 +60,6 @@ class AutofillField;
 class AutofillClient;
 class AutofillManagerTestDelegate;
 class AutofillProfile;
-class AutofillType;
 class CreditCard;
 class FormStructureBrowserTest;
 
@@ -403,19 +402,20 @@ class AutofillManager : public AutofillDownloadManager::Observer,
                         const FormStructure* cached_form,
                         FormStructure** updated_form) WARN_UNUSED_RESULT;
 
-  // Returns a list of values from the stored profiles that match |type| and the
-  // value of |field| and returns the labels of the matching profiles. |labels|
-  // is filled with the Profile label.
+  // Returns a list of values from the stored profiles that match field type
+  // |autofill_field.Type()| and the value of |field| and returns the labels of

[csashi, 2017/04/27 18:41:17]

Reorder as
"that match the value of |field| and match field type |autofill_field.Type()| to
align with order of parameters?

[jiahuiguo, 2017/05/24 18:00:00]

Moved the ukm from pollsuggestions to suggestionsShown.

+  // the matching profiles. |labels| is filled with the Profile label.
   std::vector<Suggestion> GetProfileSuggestions(
       const FormStructure& form,
       const FormFieldData& field,
       const AutofillField& autofill_field) const;
 
-  // Returns a list of values from the stored credit cards that match |type| and
-  // the value of |field| and returns the labels of the matching credit cards.
+  // Returns a list of values from the stored credit cards that match field type
+  // |autofill_field.Type()| and the value of |field| and returns the labels of
+  // the matching credit cards.

[csashi, 2017/04/27 18:41:17]

Same comment.

[jiahuiguo, 2017/05/24 18:00:00]

Acknowledged.

   std::vector<Suggestion> GetCreditCardSuggestions(
       const FormFieldData& field,
-      const AutofillType& type) const;
+      const AutofillField& autofill_field) const;
 
   // Parses the forms using heuristic matching and querying the Autofill server.
   void ParseForms(const std::vector<FormData>& forms);