chrome/test/chromedriver/chrome/web_view_impl.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Android, Fuzzer and JSON Test Fixes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chrome/web_view_impl.cc

diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc

index 219427c8c83ce23a04401b608108025e0640cc6e..24fe39db3491f3833e78889aa5d0d838e381e341 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl.cc

+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc

@@ -376,7 +376,7 @@ Status WebViewImpl::DispatchTouchEvent(const TouchEvent& event) {

point->SetString("state", GetPointStateString(event.type));

point->SetInteger("x", event.x);

point->SetInteger("y", event.y);

- point_list->Set(0, point.release());

+ point_list->Append(std::move(point));

params.Set("touchPoints", point_list.release());

return client_->SendCommand("Input.dispatchTouchEvent", params);

}