Remove base::ListValue::Set(size_t, base::Value*)

content/common/common_param_traits_unittest.cc

Index: content/common/common_param_traits_unittest.cc
diff --git a/content/common/common_param_traits_unittest.cc b/content/common/common_param_traits_unittest.cc
index fd6cd2af39f4fe42e9999a59126cf20945ca6af2..aec2b4009b9580dabf69207a7bbcc595b6208196 100644
--- a/content/common/common_param_traits_unittest.cc
+++ b/content/common/common_param_traits_unittest.cc
@@ -88,9 +88,9 @@ TEST(IPCMessageTest, Bitmap) {
 
 TEST(IPCMessageTest, ListValue) {
   base::ListValue input;
-  input.Set(0, new base::Value(42.42));
-  input.Set(1, new base::Value("forty"));
-  input.Set(2, base::MakeUnique<base::Value>());
+  input.AppendDouble(42.42);
+  input.AppendString("forty");
+  input.Append(base::MakeUnique<base::Value>());
 
   IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
   IPC::WriteParam(&msg, input);
@@ -119,9 +119,9 @@ TEST(IPCMessageTest, DictionaryValue) {
   subdict->Set("bool", new base::Value(false));
 
   std::unique_ptr<base::ListValue> sublist(new base::ListValue());
-  sublist->Set(0, new base::Value(42.42));
-  sublist->Set(1, new base::Value("forty"));
-  sublist->Set(2, new base::Value("two"));
+  sublist->AppendDouble(42.42);
+  sublist->AppendString("forty");
+  sublist->AppendString("two");
   subdict->Set("list", sublist.release());

[vabr (Chromium), 2017/04/25 17:13:15]

optional: While here, you might as well change the Set calls to get unique_ptr
arguments. While arguably this is not the main focus of the CL, it is in its
spirit, and it will avoid another CL touching this file soon.

[jdoerrie, 2017/04/26 11:34:37]

Done.

 
   input.Set("dict", subdict.release());