Remove base::ListValue::Set(size_t, base::Value*)

chrome/test/chromedriver/chrome/web_view_impl.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/chrome/web_view_impl.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 353 matching lines @@
     Status status = client_->SendCommand("Input.dispatchMouseEvent", params);
     if (status.IsError())
       return status;
   }
   return Status(kOk);
 }
 
 Status WebViewImpl::DispatchTouchEvent(const TouchEvent& event) {
   base::DictionaryValue params;
   params.SetString("type", GetAsString(event.type));
   std::unique_ptr<base::ListValue> point_list(new base::ListValue);

[vabr (Chromium), 2017/04/25 17:13:15]

optional: Move point_list definition immediately prior to its first usage.

[jdoerrie, 2017/04/26 11:34:37]

Done.

   std::unique_ptr<base::DictionaryValue> point(new base::DictionaryValue);
   point->SetString("state", GetPointStateString(event.type));
   point->SetInteger("x", event.x);
   point->SetInteger("y", event.y);
-  point_list->Set(0, point.release());
+  point_list->Append(std::move(point));
   params.Set("touchPoints", point_list.release());
   return client_->SendCommand("Input.dispatchTouchEvent", params);
 }
 
 Status WebViewImpl::DispatchTouchEvents(const std::list<TouchEvent>& events) {
   for (std::list<TouchEvent>::const_iterator it = events.begin();
        it != events.end(); ++it) {
     Status status = DispatchTouchEvent(*it);
     if (status.IsError())
       return status;
@@ skipping 531 matching lines @@
 
   if (!cmd_result->GetInteger("nodeId", node_id))
     return Status(kUnknownError, "DOM.requestNode missing int 'nodeId'");
   *found_node = true;
   return Status(kOk);
 }
 
 
 
 }  // namespace internal