chrome/browser/speech/extension_api/tts_extension_api.cc - Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api.cc

Issue 2838893002: Remove base::ListValue::Set(size_t, base::Value*) (Closed)

Patch Set: Android, Fuzzer and JSON Test Fixes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/speech/extension_api/tts_extension_api.cc

diff --git a/chrome/browser/speech/extension_api/tts_extension_api.cc b/chrome/browser/speech/extension_api/tts_extension_api.cc

index 26160e97c6029da3dd91754438539fb5f3768a6e..bfaf3526e746dc629b3dece13a40d7eeb56ab1e2 100644

--- a/chrome/browser/speech/extension_api/tts_extension_api.cc

+++ b/chrome/browser/speech/extension_api/tts_extension_api.cc

@@ -138,7 +138,7 @@ void TtsExtensionEventHandler::OnTtsEvent(Utterance* utterance,

details->SetBoolean(constants::kIsFinalEventKey, utterance->finished());

std::unique_ptr<base::ListValue> arguments(new base::ListValue());

- arguments->Set(0, details.release());

+ arguments->Append(std::move(details));

std::unique_ptr<extensions::Event> event(

new extensions::Event(::extensions::events::TTS_ON_EVENT,