Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 283883002: Remove the hard_dep flag in GN. (Closed)

Created:
6 years, 7 months ago by brettw
Modified:
6 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Remove the hard_dep flag in GN. This was not hooked up but I kept it being acceptsed until all uses can be deleted. This deletes the remaining uses from the tree. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270779

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M build/config/android/rules.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M build/util/BUILD.gn View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/gn/secondary/tools/grit/grit_rule.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/gn/target_generator.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
brettw
6 years, 7 months ago (2014-05-13 23:16:40 UTC) #1
scottmg
lgtm https://codereview.chromium.org/283883002/diff/1/mojo/public/tools/bindings/mojom.gni File mojo/public/tools/bindings/mojom.gni (left): https://codereview.chromium.org/283883002/diff/1/mojo/public/tools/bindings/mojom.gni#oldcode79 mojo/public/tools/bindings/mojom.gni:79: hard_dep = true sorry, i forget, just to ...
6 years, 7 months ago (2014-05-13 23:21:22 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 7 months ago (2014-05-15 05:02:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/283883002/20001
6 years, 7 months ago (2014-05-15 05:03:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 06:29:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 06:32:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67818) ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/16704) linux_chromium_chromeos_rel ...
6 years, 7 months ago (2014-05-15 06:32:19 UTC) #7
brettw
6 years, 7 months ago (2014-05-15 19:38:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r270779.

Powered by Google App Engine
This is Rietveld 408576698