Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: ui/base/BUILD.gn

Issue 283883002: Remove the hard_dep flag in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/target_generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index a0eca8834a0f3beb2e838558535965823f43a59f..c1d8714878614f716cb5c317f0f646adee29d720 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -503,14 +503,6 @@ component("ui_base") {
"device_form_factor_desktop.cc",
]
}
-
- # TODO(GYP): Port this to GN.
- #if (use_system_icu) {
- # When using the system icu, the icu targets generate shim headers
- # which are included by public headers in the ui target, so we need
- # ui to be a hard dependency for all its users.
- #'hard_dependency': 1,
- #}
}
source_set("ui_base_test_support") {
« no previous file with comments | « tools/gn/target_generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698