Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: tools/gn/target_generator.cc

Issue 283883002: Remove the hard_dep flag in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/secondary/tools/grit/grit_rule.gni ('k') | ui/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target_generator.cc
diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc
index cf6bc1f7d4ae10272211065d2387c928226e5114..02ed8b74cc6e202528a4eccd3a83aa7e02a4eb26 100644
--- a/tools/gn/target_generator.cc
+++ b/tools/gn/target_generator.cc
@@ -208,14 +208,6 @@ void TargetGenerator::FillDependencies() {
FillForwardDependentConfigs();
if (err_->has_error())
return;
-
- // Mark the "hard_dep" variable as used. This was previously part of GN but
- // is now unused, and we don't want to throw errors for build files setting
- // it while the new binary is being pushed.
- // TODO(brettw) remove this code when all hard_deps are removed.
- const char kHardDep[] = "hard_dep";
- if (scope_->IsSetButUnused(kHardDep))
- scope_->MarkUsed(kHardDep);
}
void TargetGenerator::FillOutputs() {
« no previous file with comments | « tools/gn/secondary/tools/grit/grit_rule.gni ('k') | ui/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698