tools/gn/secondary/tools/grit/grit_rule.gni - Issue 283883002: Remove the hard_dep flag in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/secondary/tools/grit/grit_rule.gni

Issue 283883002: Remove the hard_dep flag in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/secondary/tools/grit/grit_rule.gni

diff --git a/tools/gn/secondary/tools/grit/grit_rule.gni b/tools/gn/secondary/tools/grit/grit_rule.gni

index 789e40ea94c65f7a3be4ef9fca62f7b2532750e4..31307e4184471b0087932d7cf601b412d1d3e88a 100644

--- a/tools/gn/secondary/tools/grit/grit_rule.gni

+++ b/tools/gn/secondary/tools/grit/grit_rule.gni

@@ -67,7 +67,6 @@ template("grit") {

grit_custom_target = target_name + "_grit"

action(grit_custom_target) {

script = "//tools/grit/grit.py"

- hard_dep = true

source_prereqs = grit_inputs

outputs = grit_outputs

@@ -86,7 +85,6 @@ template("grit") {

source_set(target_name) {

# Since we generate a file, we need to be run before the targets that

# depend on us.

- hard_dep = true

sources = grit_outputs

# Deps set on the template invocation will go on the grit script running

« no previous file with comments | « tools/gn/secondary/chrome/BUILD.gn ('k') | tools/gn/target_generator.cc » ('j') | no next file with comments »