Invalidate collapsed borders using currentColor when color changes

Invalidate collapsed borders using currentColor when color changes

Also remove CollapsedBorderValue::color_is_current_color_, because
we always create CollapseBorderValue with resolved color.

BUG=713680
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2838643003
Cr-Commit-Position: refs/heads/master@{#467024}
Committed: https://chromium.googlesource.com/chromium/src/+/ed44ef1f1961716727c328153fd34b97fe8f9642

[Xianzhu, 2017-04-24 21:00:41]

Description was changed from

==========
Remove CollapsedBorderValue::color_is_current_color_

We always create CollapseBorderValue with resolved color, so it's
no need to store color_is_current_color_ which is always false.

BUG=713680
==========

to

==========
Remove CollapsedBorderValue::color_is_current_color_

We always create CollapseBorderValue with resolved color, so it's
no need to store color_is_current_color_ which is always false.

BUG=713680
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-04-24 21:00:44]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 21:02:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-04-24 21:09:21]

wangxianzhu@chromium.org changed reviewers:
+ wkorman@chromium.org

[Xianzhu, 2017-04-24 21:09:22]

https://codereview.chromium.org/2838643003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp (right):

https://codereview.chromium.org/2838643003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp:17: const
ComputedStyle& old_style) {
This doesn't include the !table->SelfNeedsLayout() and similar conditions in
StyleDidChange() methods because
- the conditions were inconsistent;
- the new code is simpler and the extra cost is trivial;
- in the future we can avoid invalidating collapsed borders on layout change,
but only on border style change and NeedsSectionRecalc instead.

https://codereview.chromium.org/2838643003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/CollapsedBorderValue.h (right):

https://codereview.chromium.org/2838643003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/CollapsedBorderValue.h:45: const Color&
color,
Actually we always pass Color instead of StyleColor here. Previously the Color
passed in was automatically converted into StyleColor whose IsCurrentColor() was
always false.

[Xianzhu, 2017-04-24 21:11:09]

Description was changed from

==========
Remove CollapsedBorderValue::color_is_current_color_

We always create CollapseBorderValue with resolved color, so it's
no need to store color_is_current_color_ which is always false.

BUG=713680
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Invalidate collapsed borders using currentColor when color changes

Also remove CollapsedBorderValue::color_is_current_color_, because
we always create CollapseBorderValue with resolved color.

BUG=713680
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-04-24 21:11:16]

Forgot to update the CL title and description when sending out the CL. Updated.

[Xianzhu, 2017-04-24 21:21:30]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 21:21:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2017-04-24 21:46:00]

lgtm

Update change subject to reflect updated CL desc.

[Xianzhu, 2017-04-24 22:05:12]

On 2017/04/24 21:46:00, wkorman wrote:
> lgtm
> 
> Update change subject to reflect updated CL desc.

Done. Please also review https://codereview.chromium.org/2836143003/ on which
this CL depends.

[commit-bot: I haz the power, 2017-04-24 23:05:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 23:05:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-04-25 15:26:34]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-04-25 15:26:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 17:10:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493133994852550,
"parent_rev": "ad9a135a3aee046fbe60245153c7e67d435bc7d8", "commit_rev":
"ed44ef1f1961716727c328153fd34b97fe8f9642"}

[commit-bot: I haz the power, 2017-04-25 17:10:10]

Description was changed from

==========
Invalidate collapsed borders using currentColor when color changes

Also remove CollapsedBorderValue::color_is_current_color_, because
we always create CollapseBorderValue with resolved color.

BUG=713680
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Invalidate collapsed borders using currentColor when color changes

Also remove CollapsedBorderValue::color_is_current_color_, because
we always create CollapseBorderValue with resolved color.

BUG=713680
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2838643003
Cr-Commit-Position: refs/heads/master@{#467024}
Committed:
https://chromium.googlesource.com/chromium/src/+/ed44ef1f1961716727c328153fd3...
==========

[commit-bot: I haz the power, 2017-04-25 17:10:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ed44ef1f1961716727c328153fd3...