Invalidate border/outline on color change only if they use current color

Invalidate border/outline on color change only if they use current color

The new ComputedStyle::HasBorderColorReferencingCurrentColor() is also
useful for fixing crbug.com/713680.

BUG=713680
Review-Url: https://codereview.chromium.org/2836143003
Cr-Commit-Position: refs/heads/master@{#466923}
Committed: https://chromium.googlesource.com/chromium/src/+/5ce0f7d183fa6870c877696c6ef1302a945f2e5e

[Xianzhu, 2017-04-24 20:38:15]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2017-04-24 20:38:37]

wangxianzhu@chromium.org changed reviewers:
+ wkorman@chromium.org

[commit-bot: I haz the power, 2017-04-24 20:39:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2017-04-24 22:05:42]

lgtm

https://codereview.chromium.org/2836143003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2836143003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1546: if
(Style()->HasBorderColorReferencingCurrentColor() ||
Could add unit tests for this, BorderData, and ComputedStyle (in separate
*Test.cpp each). Would be trivial tests but I think nice to start building them
up. BorderDataTest does not exist but the others do.

Layout test obviously covers end behavior.

[Xianzhu, 2017-04-24 22:36:48]

https://codereview.chromium.org/2836143003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2836143003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1546: if
(Style()->HasBorderColorReferencingCurrentColor() ||
On 2017/04/24 22:05:41, wkorman wrote:
> Could add unit tests for this, BorderData, and ComputedStyle (in separate
> *Test.cpp each). Would be trivial tests but I think nice to start building
them
> up. BorderDataTest does not exist but the others do.
> 
> Layout test obviously covers end behavior.

Added ComputedStyleTest.HasOutlineWithCurrentColor and
ComputedStyleTest.HasBorderColorReferencingCurrentColor. Not BorderDataTest
because ComputedStyle controls how BorderData mutates. Using friend test would
just exposes BorderData as a struct and the tested code is too different from
actual executed code.

[Xianzhu, 2017-04-24 22:36:53]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-04-24 22:36:53]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2836143003/#ps20001
(title: "-")

[commit-bot: I haz the power, 2017-04-24 22:37:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 00:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 00:36:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2017-04-25 06:31:05]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-04-25 06:31:06]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2836143003/#ps40001
(title: "rebaselined")

[commit-bot: I haz the power, 2017-04-25 06:31:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 08:25:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493101865473870,
"parent_rev": "b1d346cc88d41c6a5b1dd5ac47327c9ee7c6d7e7", "commit_rev":
"5ce0f7d183fa6870c877696c6ef1302a945f2e5e"}

[commit-bot: I haz the power, 2017-04-25 08:25:28]

Description was changed from

==========
Invalidate border/outline on color change only if they use current color

The new ComputedStyle::HasBorderColorReferencingCurrentColor() is also
useful for fixing crbug.com/713680.

BUG=713680
==========

to

==========
Invalidate border/outline on color change only if they use current color

The new ComputedStyle::HasBorderColorReferencingCurrentColor() is also
useful for fixing crbug.com/713680.

BUG=713680

Review-Url: https://codereview.chromium.org/2836143003
Cr-Commit-Position: refs/heads/master@{#466923}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ce0f7d183fa6870c877696c6ef1...
==========

[commit-bot: I haz the power, 2017-04-25 08:25:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5ce0f7d183fa6870c877696c6ef1...