Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(132)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-current-color-expected.html
Issue
2838643003
:
Invalidate collapsed borders using currentColor when color changes (Closed)
Patch Set: -
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-current-color.html
third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-current-color-expected.html
third_party/WebKit/Source/core/layout/LayoutTable.cpp
third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h
third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp
third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
third_party/WebKit/Source/core/paint/TableCellPainter.cpp
third_party/WebKit/Source/core/style/CollapsedBorderValue.h
View unified diff
|
Download patch
« no previous file with comments
|
« third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-current-color.html
('k') |
third_party/WebKit/Source/core/layout/LayoutTable.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<style>
3
table {
4
border-collapse: collapse;
5
margin: 30px;
6
}
7
td {
8
width: 100px;
9
height: 50px;
10
border: 10px solid green;
11
}
12
body {
13
color: green;
14
}
15
</style>
16
All borders should change to green.
17
<table><tr><td></td></tr></table>
18
<table><tr><td></td></tr></table>
19
<!--
20
TODO(wangxianzhu): Enable these after crbug.com/626748 is fixed.
21
<table><tr><td></td></tr></table>
22
<table><tr><td></td></tr></table>
23
-->
24
<table><tr><td></td></tr></table>
OLD
NEW
« no previous file with comments
|
« third_party/WebKit/LayoutTests/paint/invalidation/table/collapsed-border-current-color.html
('k') |
third_party/WebKit/Source/core/layout/LayoutTable.cpp »
('j') |
no next file with comments »
Issue 2838643003: Invalidate collapsed borders using currentColor when color changes (Closed)
Created 3 years, 7 months ago by Xianzhu
Modified 3 years, 7 months ago
Reviewers: wkorman
Base URL:
Comments: 2
This is Rietveld
408576698