Blink Rename follow-up: Rename PrintContext::begin/end to Begin/EndPrintMode.

Blink Rename follow-up: Rename PrintContext::begin/end to Begin/EndPrintMode.

The renaming tool skipped renaming |begin| and |end| methods with an
assumption that they should mimic STL naming convention in all cases.
This assumption is not true for PrintContext::begin and
PrintContext::end methods - this CL renames them to the Chromium style
(expanding their names to BeginPrintMode and EndPrintMode).

BUG=675877
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2838343003
Cr-Commit-Position: refs/heads/master@{#467564}
Committed: https://chromium.googlesource.com/chromium/src/+/f40fd439d92c1c788d54e71dae144c6dead3efe6

[Łukasz Anforowicz, 2017-04-26 17:33:18]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 17:34:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 17:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 17:50:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2017-04-26 20:10:38]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 20:11:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 22:04:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 22:04:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2017-04-26 22:28:10]

thestig@, could you PTAL?

PS. I am rerunning linux_chromium_rel_ng tryjob, because I think (hope?) the
redness in 2 layout tests is not related to my changes.

https://codereview.chromium.org/2838343003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/PrintContext.h (right):

https://codereview.chromium.org/2838343003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/PrintContext.h:79: virtual void
BeginPrintMode(float width, float height = 0);
|BeginPrintMode| seems like a good name to me, because the doc comment above
says "Enter print mode".

[Lei Zhang, 2017-04-26 22:33:54]

lgtm, but not an owner.

[Łukasz Anforowicz, 2017-04-26 22:55:32]

lukasza@chromium.org changed reviewers:
+ tkent@chromium.org

[Łukasz Anforowicz, 2017-04-26 22:55:32]

tkent@, could you PTAL as an owner of third_party/WebKit/Source/web and
third_party/WebKit/Source/core?

[tkent, 2017-04-26 23:33:05]

lgtm

[Łukasz Anforowicz, 2017-04-27 02:21:10]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-04-27 02:22:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 03:17:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493259670864750,
"parent_rev": "700d8c729c8d08f6aa42f15343f297ff5cfdf393", "commit_rev":
"f40fd439d92c1c788d54e71dae144c6dead3efe6"}

[commit-bot: I haz the power, 2017-04-27 03:18:14]

Description was changed from

==========
Blink Rename follow-up: Rename PrintContext::begin/end to Begin/EndPrintMode.

The renaming tool skipped renaming |begin| and |end| methods with an
assumption that they should mimic STL naming convention in all cases.
This assumption is not true for PrintContext::begin and
PrintContext::end methods - this CL renames them to the Chromium style
(expanding their names to BeginPrintMode and EndPrintMode).

BUG=675877
R=thestig@chromium.org
==========

to

==========
Blink Rename follow-up: Rename PrintContext::begin/end to Begin/EndPrintMode.

The renaming tool skipped renaming |begin| and |end| methods with an
assumption that they should mimic STL naming convention in all cases.
This assumption is not true for PrintContext::begin and
PrintContext::end methods - this CL renames them to the Chromium style
(expanding their names to BeginPrintMode and EndPrintMode).

BUG=675877
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2838343003
Cr-Commit-Position: refs/heads/master@{#467564}
Committed:
https://chromium.googlesource.com/chromium/src/+/f40fd439d92c1c788d54e71dae14...
==========

[commit-bot: I haz the power, 2017-04-27 03:18:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f40fd439d92c1c788d54e71dae14...