Blink Rename follow-up: Rename PrintContext::begin/end to Begin/EndPrintMode.

third_party/WebKit/Source/core/page/PrintContext.h

 /*
  * Copyright (C) 2007 Alp Toker <alp@atoker.com>
  * Copyright (C) 2007 Apple Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 30 matching lines @@
 class CORE_EXPORT PrintContext
     : public GarbageCollectedFinalized<PrintContext> {
  public:
   explicit PrintContext(LocalFrame*);
   virtual ~PrintContext();
 
   LocalFrame* GetFrame() const { return frame_; }
 
   // Break up a page into rects without relayout.
   // FIXME: This means that CSS page breaks won't be on page boundary if the
-  // size is different than what was passed to begin(). That's probably not
-  // always desirable.
+  // size is different than what was passed to BeginPrintMode(). That's probably
+  // not always desirable.
   // FIXME: Header and footer height should be applied before layout, not after.
   // FIXME: The printRect argument is only used to determine page aspect ratio,
   // it would be better to pass a FloatSize with page dimensions instead.
   virtual void ComputePageRects(const FloatRect& print_rect,
                                 float header_height,
                                 float footer_height,
                                 float user_scale_factor,
                                 float& out_page_height);
 
   // Deprecated. Page size computation is already in this class, clients
   // shouldn't be copying it.
   // FIXME: Everyone passes |false| for the second paramer. We should remove the
   // second parameter.
   virtual void ComputePageRectsWithPageSize(
       const FloatSize& page_size_in_pixels);
 
   // These are only valid after page rects are computed.
   size_t PageCount() const { return page_rects_.size(); }
   const IntRect& PageRect(size_t page_number) const {
     return page_rects_[page_number];
   }
   const Vector<IntRect>& PageRects() const { return page_rects_; }
 
   // Enter print mode, updating layout for new page size.
   // This function can be called multiple times to apply new print options
   // without going back to screen mode.
-  virtual void begin(float width, float height = 0);
+  virtual void BeginPrintMode(float width, float height = 0);

[Łukasz Anforowicz, 2017/04/26 22:28:10]

|BeginPrintMode| seems like a good name to me, because the doc comment above
says "Enter print mode".

 
   // Return to screen mode.
-  virtual void end();
+  virtual void EndPrintMode();
 
   // Used by layout tests.
   static int PageNumberForElement(
       Element*,
       const FloatSize& page_size_in_pixels);  // Returns -1 if page isn't found.
   static String PageProperty(LocalFrame*,
                              const char* property_name,
                              int page_number);
   static bool IsPageBoxVisible(LocalFrame*, int page_number);
   static String PageSizeAndMarginsInPixels(LocalFrame*,
@@ skipping 12 matching lines @@
   void OutputLinkedDestinations(GraphicsContext&, const IntRect& page_rect);
 
   Member<LocalFrame> frame_;
   Vector<IntRect> page_rects_;
 
  private:
   void ComputePageRectsWithPageSizeInternal(
       const FloatSize& page_size_in_pixels);
   void CollectLinkedDestinations(Node*);
 
-  // Used to prevent misuses of begin() and end() (e.g., call end without
-  // begin).
+  // Used to prevent misuses of BeginPrintMode() and EndPrintMode() (e.g., call
+  // EndPrintMode without BeginPrintMode).
   bool is_printing_;
 
   HeapHashMap<String, Member<Element>> linked_destinations_;
   bool linked_destinations_valid_;
 };
 
 }  // namespace blink
 
 #endif