Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2838343003: Blink Rename follow-up: Rename PrintContext::begin/end to Begin/EndPrintMode. (Closed)
Patch Set: Fix compilation of PrintContextTest.cpp Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 7575f0ab473f95fbe782f504c6ed7c754971d18a..d09055584dd50aed421de73dfcf0a9083d65fafa 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -280,11 +280,11 @@ class ChromePrintContext : public PrintContext {
~ChromePrintContext() override {}
- virtual void begin(float width, float height) {
+ virtual void BeginPrintMode(float width, float height) {
DCHECK(!printed_page_width_);
printed_page_width_ = width;
printed_page_height_ = height;
- PrintContext::begin(printed_page_width_, height);
+ PrintContext::BeginPrintMode(printed_page_width_, height);
}
virtual float GetPageShrink(int page_number) const {
@@ -455,9 +455,9 @@ class ChromePluginPrintContext final : public ChromePrintContext {
ChromePrintContext::Trace(visitor);
}
- void begin(float width, float height) override {}
+ void BeginPrintMode(float width, float height) override {}
- void end() override { plugin_->PrintEnd(); }
+ void EndPrintMode() override { plugin_->PrintEnd(); }
float GetPageShrink(int page_number) const override {
// We don't shrink the page (maybe we should ask the widget ??)
@@ -1401,7 +1401,7 @@ int WebLocalFrameImpl::PrintBegin(const WebPrintParams& print_params,
FloatRect rect(0, 0,
static_cast<float>(print_params.print_content_area.width),
static_cast<float>(print_params.print_content_area.height));
- print_context_->begin(rect.Width(), rect.Height());
+ print_context_->BeginPrintMode(rect.Width(), rect.Height());
float page_height;
// We ignore the overlays calculation for now since they are generated in the
// browser. pageHeight is actually an output parameter.
@@ -1427,7 +1427,7 @@ float WebLocalFrameImpl::PrintPage(int page, WebCanvas* canvas) {
void WebLocalFrameImpl::PrintEnd() {
DCHECK(print_context_);
- print_context_->end();
+ print_context_->EndPrintMode();
print_context_.Clear();
}

Powered by Google App Engine
This is Rietveld 408576698