Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: content/browser/loader/resource_loader_unittest.cc

Issue 2838243002: Remove client_certs from SSLCertRequestInfo. (Closed)
Patch Set: revert stray whitespace change Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/cast_content_browser_client.cc ('k') | content/browser/ssl/ssl_client_auth_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_loader_unittest.cc
diff --git a/content/browser/loader/resource_loader_unittest.cc b/content/browser/loader/resource_loader_unittest.cc
index 5c526b592a8394d4ee23a235114a8afa8d226662..ff068e7a74036bb4bc3a7f589818649156062b22 100644
--- a/content/browser/loader/resource_loader_unittest.cc
+++ b/content/browser/loader/resource_loader_unittest.cc
@@ -90,13 +90,11 @@ class ClientCertStoreStub : public net::ClientCertStore {
// net::ClientCertStore:
void GetClientCerts(const net::SSLCertRequestInfo& cert_request_info,
- net::CertificateList* selected_certs,
- const base::Closure& callback) override {
+ const ClientCertListCallback& callback) override {
*requested_authorities_ = cert_request_info.cert_authorities;
++(*request_count_);
- *selected_certs = response_;
- callback.Run();
+ callback.Run(response_);
}
private:
@@ -118,14 +116,13 @@ class LoaderDestroyingCertStore : public net::ClientCertStore {
on_loader_deleted_callback_(on_loader_deleted_callback) {}
// net::ClientCertStore:
- void GetClientCerts(const net::SSLCertRequestInfo& cert_request_info,
- net::CertificateList* selected_certs,
- const base::Closure& cert_selected_callback) override {
+ void GetClientCerts(
+ const net::SSLCertRequestInfo& cert_request_info,
+ const ClientCertListCallback& cert_selected_callback) override {
// Don't destroy |loader_| while it's on the stack.
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(&LoaderDestroyingCertStore::DoCallback,
- base::Unretained(loader_),
- cert_selected_callback,
+ base::Unretained(loader_), cert_selected_callback,
on_loader_deleted_callback_));
}
@@ -134,10 +131,10 @@ class LoaderDestroyingCertStore : public net::ClientCertStore {
// LoaderDestroyingCertStore (ClientCertStores are actually handles, and not
// global cert stores).
static void DoCallback(std::unique_ptr<ResourceLoader>* loader,
- const base::Closure& cert_selected_callback,
+ const ClientCertListCallback& cert_selected_callback,
const base::Closure& on_loader_deleted_callback) {
loader->reset();
- cert_selected_callback.Run();
+ cert_selected_callback.Run(net::CertificateList());
on_loader_deleted_callback.Run();
}
@@ -280,11 +277,12 @@ class SelectCertificateBrowserClient : public TestContentBrowserClient {
void SelectClientCertificate(
WebContents* web_contents,
net::SSLCertRequestInfo* cert_request_info,
+ net::CertificateList client_certs,
std::unique_ptr<ClientCertificateDelegate> delegate) override {
EXPECT_FALSE(delegate_.get());
++call_count_;
- passed_certs_ = cert_request_info->client_certs;
+ passed_certs_ = std::move(client_certs);
delegate_ = std::move(delegate);
select_certificate_run_loop_.Quit();
}
« no previous file with comments | « chromecast/browser/cast_content_browser_client.cc ('k') | content/browser/ssl/ssl_client_auth_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698