|
Revert of Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer. (patchset #4 id:60001 of https://codereview.chromium.org/2831733003/ )
Reason for revert:
Reverting because 4 gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLContextLost* tests and GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash crash on "Mac Retina Debug (AMD)" bot.
Original issue's description:
> Fix blits from multisampled renderbuffers to alpha:false WebGL back buffer.
>
> Blitting from a multisampled RGB8 renderbuffer to an alpha:false WebGL
> back buffer is supposed to work, and from an RGBA8 renderbuffer is
> supposed to not work. The emulation of IOSurface-backed RGB textures
> using RGBA textures didn't handle this case.
>
> Add BindTexImage2DWithInternalformatCHROMIUM to the command buffer to
> allow internal format to be overridden; currently this is only
> supported on macOS. Use this to bind a second texture to the IOSurface
> and use it only for BlitFramebuffer calls from WebGL, fixing up the
> alpha channel afterward.
>
> Covered by new conformance test in
> https://github.com/KhronosGroup/WebGL/pull/2377 .
>
> BUG= 699566
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2831733003
> Cr-Commit-Position: refs/heads/master@{#466523}
> Committed: https://chromium.googlesource.com/chromium/src/+/3d4d5d7a9198bea6f0018a36fc6825637f9a12c4
TBR=zmo@chromium.org,ccameron@chromium.org,kbr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 699566
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+115 lines, -523 lines) |
Patch |
|
M |
content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt
|
View
|
|
2 chunks |
+5 lines, -35 lines |
0 comments
|
Download
|
|
M |
gpu/GLES2/gl2chromium_autogen.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
gpu/GLES2/gl2extchromium.h
|
View
|
|
3 chunks |
+15 lines, -16 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/build_gles2_cmd_buffer.py
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_c_lib_autogen.h
|
View
|
|
2 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_cmd_helper_autogen.h
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_implementation_autogen.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_implementation_impl_autogen.h
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_implementation_unittest_autogen.h
|
View
|
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_interface_autogen.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_interface_stub_autogen.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_trace_implementation_autogen.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/cmd_buffer_functions.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
gpu/command_buffer/common/gles2_cmd_format_autogen.h
|
View
|
|
1 chunk |
+0 lines, -46 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
|
View
|
|
1 chunk |
+0 lines, -15 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/common/gles2_cmd_ids_autogen.h
|
View
|
|
1 chunk |
+53 lines, -54 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/gles2_cmd_decoder.cc
|
View
|
|
4 chunks |
+15 lines, -43 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
|
View
|
|
1 chunk |
+0 lines, -18 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
|
View
|
|
1 chunk |
+0 lines, -28 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
|
View
|
|
1 chunk |
+16 lines, -9 lines |
0 comments
|
Download
|
|
M |
gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers_autogen.cc
|
View
|
|
1 chunk |
+0 lines, -18 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h
|
View
|
|
5 chunks |
+2 lines, -31 lines |
0 comments
|
Download
|
|
M |
third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
|
View
|
|
4 chunks |
+0 lines, -90 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_image.h
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_image.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_image_io_surface.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
ui/gl/gl_image_io_surface.mm
|
View
|
|
3 chunks |
+6 lines, -14 lines |
0 comments
|
Download
|
Total messages: 7 (3 generated)
|