Cleanup PDF plugin code.

Cleanup PDF plugin code.

- Consolidate callback factories in OutOfProcessInstance.
- Make PDFEngine::Create() return a unique_ptr.
- Unify LoadUrl methods.

Review-Url: https://codereview.chromium.org/2837663002
Cr-Commit-Position: refs/heads/master@{#469377}
Committed: https://chromium.googlesource.com/chromium/src/+/66a2016758be5a47057b8580f9d0432b7de570f8

[Lei Zhang, 2017-04-21 21:04:37]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 21:05:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-04-21 21:05:45]

thestig@chromium.org changed reviewers:
+ raymes@chromium.org

[Lei Zhang, 2017-04-21 21:05:45]

We don't need all these callback factories, right? Should the callback factory
be last, like WeakPtr factories elsewhere?

[commit-bot: I haz the power, 2017-04-21 21:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 21:54:52]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-04-23 22:19:00]

Hey Lei, I'd actually like to start transitioning away from being a PDF owner
given that my focus now lies elsewhere. Do you think it makes more sense for
dsinclair@ or someone else to review with the hope of adding to the OWNERS file
eventually? Happy to review things if you really need my input :)

[Lei Zhang, 2017-04-24 04:08:21]

On 2017/04/23 22:19:00, raymes wrote:
> Hey Lei, I'd actually like to start transitioning away from being a PDF owner
> given that my focus now lies elsewhere. Do you think it makes more sense for
> dsinclair@ or someone else to review with the hope of adding to the OWNERS
file
> eventually? Happy to review things if you really need my input :)

Sure, but I figured you know more about PPAPI than the rest of us. Thus asking
you to review.

[raymes, 2017-04-26 02:44:20]

lgtm

> We don't need all these callback factories, right? 

I don't think so.

> Should the callback factory be last, like WeakPtr factories elsewhere?

I'm not sure about the answer to that actually.

https://codereview.chromium.org/2837663002/diff/1/pdf/out_of_process_instance.cc
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/2837663002/diff/1/pdf/out_of_process_instance...
pdf/out_of_process_instance.cc:385: LoadUrl(stream_url, false /*
is_print_preview */);
I just had advice from thakis@ that /*is_print_preview=*/ is now preferred
because clang can check it.

https://codereview.chromium.org/2837663002/diff/1/pdf/out_of_process_instance...
pdf/out_of_process_instance.cc:1525: is_print_preview ? embed_preview_loader_ :
embed_loader_;
This is a bit subtle to me. Maybe it's just because we don't use non-const
references much in Chrome though.

[Lei Zhang, 2017-05-04 09:22:20]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 09:22:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 10:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 10:01:10]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-05-04 17:39:28]

https://codereview.chromium.org/2837663002/diff/1/pdf/out_of_process_instance.cc
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/2837663002/diff/1/pdf/out_of_process_instance...
pdf/out_of_process_instance.cc:385: LoadUrl(stream_url, false /*
is_print_preview */);
On 2017/04/26 02:44:19, raymes wrote:
> I just had advice from thakis@ that /*is_print_preview=*/ is now preferred
> because clang can check it.

Done.

https://codereview.chromium.org/2837663002/diff/1/pdf/out_of_process_instance...
pdf/out_of_process_instance.cc:1525: is_print_preview ? embed_preview_loader_ :
embed_loader_;
On 2017/04/26 02:44:19, raymes wrote:
> This is a bit subtle to me. Maybe it's just because we don't use non-const
> references much in Chrome though. 

Back to pointers.

[Lei Zhang, 2017-05-04 17:39:33]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-05-04 17:39:33]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2837663002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2017-05-04 17:39:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 17:44:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493919573160380,
"parent_rev": "34237b5d0662bf565c15e9f5ea14a895d06c17c9", "commit_rev":
"66a2016758be5a47057b8580f9d0432b7de570f8"}

[commit-bot: I haz the power, 2017-05-04 17:44:46]

Description was changed from

==========
Cleanup PDF plugin code.

- Consolidate callback factories in OutOfProcessInstance.
- Make PDFEngine::Create() return a unique_ptr.
- Unify LoadUrl methods.
==========

to

==========
Cleanup PDF plugin code.

- Consolidate callback factories in OutOfProcessInstance.
- Make PDFEngine::Create() return a unique_ptr.
- Unify LoadUrl methods.

Review-Url: https://codereview.chromium.org/2837663002
Cr-Commit-Position: refs/heads/master@{#469377}
Committed:
https://chromium.googlesource.com/chromium/src/+/66a2016758be5a47057b8580f9d0...
==========

[commit-bot: I haz the power, 2017-05-04 17:44:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/66a2016758be5a47057b8580f9d0...