Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pdf/pdf_engine.h

Issue 2837663002: Cleanup PDF plugin code. (Closed)
Patch Set: comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdf/out_of_process_instance.cc ('k') | pdf/pdfium/pdfium_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdf_engine.h
diff --git a/pdf/pdf_engine.h b/pdf/pdf_engine.h
index 2688f25a4943cae92f2449331ab0d8df8d99809e..3a271e2d1cd178d059acb588f8d5fbac91c08bcf 100644
--- a/pdf/pdf_engine.h
+++ b/pdf/pdf_engine.h
@@ -13,6 +13,7 @@
#include <windows.h>
#endif
+#include <memory>
#include <string>
#include <vector>
@@ -189,7 +190,7 @@ class PDFEngine {
};
// Factory method to create an instance of the PDF Engine.
- static PDFEngine* Create(Client* client);
+ static std::unique_ptr<PDFEngine> Create(Client* client);
virtual ~PDFEngine() {}
« no previous file with comments | « pdf/out_of_process_instance.cc ('k') | pdf/pdfium/pdfium_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698