Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: pdf/out_of_process_instance.h

Issue 2837663002: Cleanup PDF plugin code. (Closed)
Patch Set: comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/out_of_process_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/out_of_process_instance.h
diff --git a/pdf/out_of_process_instance.h b/pdf/out_of_process_instance.h
index f2435bc69c4ea6f34592e04e61775aea2b0bd2e1..22e1974ba1d2d64e8ecc38255e5671ce922cabdc 100644
--- a/pdf/out_of_process_instance.h
+++ b/pdf/out_of_process_instance.h
@@ -163,11 +163,7 @@ class OutOfProcessInstance : public pp::Instance,
// Draws a rectangle with the specified dimensions and color in our buffer.
void FillRect(const pp::Rect& rect, uint32_t color);
- void LoadUrl(const std::string& url);
- void LoadPreviewUrl(const std::string& url);
- void LoadUrlInternal(const std::string& url,
- pp::URLLoader* loader,
- void (OutOfProcessInstance::*method)(int32_t));
+ void LoadUrl(const std::string& url, bool is_print_preview);
// Creates a URL loader and allows it to access all urls, i.e. not just the
// frame's origin.
@@ -217,14 +213,11 @@ class OutOfProcessInstance : public pp::Instance,
pp::ImageData image_data_;
// Used when the plugin is embedded in a page and we have to create the loader
// ourself.
- pp::CompletionCallbackFactory<OutOfProcessInstance> loader_factory_;
pp::URLLoader embed_loader_;
pp::URLLoader embed_preview_loader_;
PP_CursorType_Dev cursor_; // The current cursor.
- pp::CompletionCallbackFactory<OutOfProcessInstance> timer_factory_;
-
// Size, in pixels, of plugin rectangle.
pp::Size plugin_size_;
// Size, in DIPs, of plugin rectangle.
@@ -301,11 +294,9 @@ class OutOfProcessInstance : public pp::Instance,
std::string url_;
// Used for submitting forms.
- pp::CompletionCallbackFactory<OutOfProcessInstance> form_factory_;
pp::URLLoader form_loader_;
- // Used for printing without re-entrancy issues.
- pp::CompletionCallbackFactory<OutOfProcessInstance> print_callback_factory_;
+ pp::CompletionCallbackFactory<OutOfProcessInstance> callback_factory_;
// The callback for receiving the password from the page.
std::unique_ptr<pp::CompletionCallbackWithOutput<pp::Var>> password_callback_;
« no previous file with comments | « no previous file | pdf/out_of_process_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698