IndexedDB: Add [SameObject] / [NewObject] annotations per spec

third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.idl

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  */
 
 // https://w3c.github.io/IndexedDB/#idl-def-IDBObjectStore
 
 [
     Exposed=(Window,Worker),
 ] interface IDBObjectStore {
     [RaisesException=Setter] attribute DOMString name;
     [CallWith=ScriptState] readonly attribute any keyPath;
     readonly attribute DOMStringList indexNames;
-    readonly attribute IDBTransaction transaction;
+    [SameObject] readonly attribute IDBTransaction transaction;
     readonly attribute boolean autoIncrement;
 
-    [CallWith=ScriptState, RaisesException] IDBRequest put(any value, [Default=Undefined] optional any key);
-    [CallWith=ScriptState, RaisesException] IDBRequest add(any value, [Default=Undefined] optional any key);
-    [CallWith=ScriptState, ImplementedAs=deleteFunction, RaisesException] IDBRequest delete(any key);
-    [CallWith=ScriptState, RaisesException] IDBRequest clear();
-    [CallWith=ScriptState, RaisesException] IDBRequest get(any key);
-    [CallWith=ScriptState, RaisesException] IDBRequest getKey(any key);
+    [NewObject, CallWith=ScriptState, RaisesException] IDBRequest put(any value, [NewObject, Default=Undefined] optional any key);
+    [NewObject, CallWith=ScriptState, RaisesException] IDBRequest add(any value, [NewObject, Default=Undefined] optional any key);
+    [NewObject, CallWith=ScriptState, ImplementedAs=deleteFunction, RaisesException] IDBRequest delete(any key);
+    [NewObject, CallWith=ScriptState, RaisesException] IDBRequest clear();
+    [NewObject, CallWith=ScriptState, RaisesException] IDBRequest get(any key);
+    [NewObject, CallWith=ScriptState, RaisesException] IDBRequest getKey(any key);
     // TODO(cmumford): 0xFFFFFFFF is not necessary. Remove once crbug.com/335871 is fixed.
-    [CallWith=ScriptState, RaisesException] IDBRequest getAll([Default=Undefined] optional any range, [EnforceRange] optional unsigned long maxCount = 0xFFFFFFFF);
+    [NewObject, NewObject, CallWith=ScriptState, RaisesException] IDBRequest getAll([Default=Undefined] optional any range,

[foolip, 2017/04/25 18:29:11]

A very, very new object :)

Maybe search to see if there were more like this I didn't spot.

[jsbell, 2017/04/25 18:39:50]

D'oh. There were a couple more up above too. 

+                                                                                    [EnforceRange] optional unsigned long maxCount = 0xFFFFFFFF);
     // TODO(cmumford): 0xFFFFFFFF is not necessary. Remove once crbug.com/335871 is fixed.
-    [CallWith=ScriptState, RaisesException] IDBRequest getAllKeys([Default=Undefined] optional any range, [EnforceRange] optional unsigned long maxCount = 0xFFFFFFFF);
-    [CallWith=ScriptState, RaisesException] IDBRequest count([Default=Undefined] optional any key);
-    [CallWith=ScriptState, RaisesException] IDBRequest openCursor([Default=Undefined] optional any range, optional IDBCursorDirection direction = "next");
-    [CallWith=ScriptState, RaisesException] IDBRequest openKeyCursor([Default=Undefined] optional any range, optional IDBCursorDirection direction = "next");
-    [CallWith=ScriptState, RaisesException] IDBIndex createIndex(DOMString name, (DOMString or sequence<DOMString>) keyPath, optional IDBIndexParameters options);
+    [NewObject, CallWith=ScriptState, RaisesException] IDBRequest getAllKeys([Default=Undefined] optional any range,
+                                                                             [EnforceRange] optional unsigned long maxCount = 0xFFFFFFFF);
+    [NewObject, CallWith=ScriptState, RaisesException] IDBRequest count([Default=Undefined] optional any key);
+
+    [NewObject, CallWith=ScriptState, RaisesException] IDBRequest openCursor([Default=Undefined] optional any range,
+                                                                             optional IDBCursorDirection direction = "next");
+    [NewObject, CallWith=ScriptState, RaisesException] IDBRequest openKeyCursor([Default=Undefined] optional any range,
+                                                                                optional IDBCursorDirection direction = "next");
+
     [RaisesException] IDBIndex index(DOMString name);
+    [NewObject, CallWith=ScriptState, RaisesException] IDBIndex createIndex(DOMString name,
+                                                                            (DOMString or sequence<DOMString>) keyPath,
+                                                                            optional IDBIndexParameters options);
     [RaisesException] void deleteIndex(DOMString name);
 };