Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2837543002: Test network annotation tags added to unittests in net/url_request. (Closed)

Created:
3 years, 8 months ago by Ramin Halavati
Modified:
3 years, 7 months ago
Reviewers:
asanka
CC:
chromium-reviews, Paweł Hajdan Jr., cbentzel+watch_chromium.org, fuzzing_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Test network annotation tags added to unittests in net/url_request. Test network annotation tags added to network requests of: net/url_request/url_request_context_builder_unittest.cc net/url_request/url_request_file_dir_job_unittest.cc net/url_request/url_request_file_job_unittest.cc net/url_request/url_request_filter_unittest.cc net/url_request/url_request_ftp_fuzzer.cc net/url_request/url_request_ftp_job_unittest.cc net/url_request/url_request_fuzzer.cc net/url_request/url_request_http_job_unittest.cc net/url_request/url_request_job_factory_impl_unittest.cc net/url_request/url_request_job_unittest.cc net/url_request/url_request_quic_unittest.cc net/url_request/url_request_simple_job_unittest.cc net/url_request/url_request_throttler_simulation_unittest.cc net/url_request/url_request_throttler_unittest.cc net/url_request/url_request_unittest.cc BUG=656607 Review-Url: https://codereview.chromium.org/2837543002 Cr-Commit-Position: refs/heads/master@{#467591} Committed: https://chromium.googlesource.com/chromium/src/+/b7bd7c79d7c9e89dc91746bba19a40ef8ec3b116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+698 lines, -483 lines) Patch
M net/url_request/url_request_context_builder_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/url_request/url_request_file_dir_job_unittest.cc View 6 chunks +13 lines, -8 lines 0 comments Download
M net/url_request/url_request_file_job_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/url_request/url_request_filter_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/url_request/url_request_ftp_fuzzer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/url_request_ftp_job_unittest.cc View 16 chunks +34 lines, -23 lines 0 comments Download
M net/url_request/url_request_fuzzer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/url_request/url_request_http_job_unittest.cc View 27 chunks +74 lines, -51 lines 0 comments Download
M net/url_request/url_request_job_factory_impl_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M net/url_request/url_request_job_unittest.cc View 12 chunks +26 lines, -14 lines 0 comments Download
M net/url_request/url_request_quic_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/url_request/url_request_simple_job_unittest.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M net/url_request/url_request_throttler_simulation_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/url_request/url_request_throttler_unittest.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 257 chunks +497 lines, -359 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Ramin Halavati
I've added test annotation tags to net/url_request unittests. Please review.
3 years, 8 months ago (2017-04-21 08:15:27 UTC) #6
asanka
lgtm
3 years, 7 months ago (2017-04-26 20:18:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837543002/1
3 years, 7 months ago (2017-04-27 04:39:02 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 05:26:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7bd7c79d7c9e89dc91746bba19a...

Powered by Google App Engine
This is Rietveld 408576698