Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: net/url_request/url_request_file_dir_job_unittest.cc

Issue 2837543002: Test network annotation tags added to unittests in net/url_request. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_file_dir_job_unittest.cc
diff --git a/net/url_request/url_request_file_dir_job_unittest.cc b/net/url_request/url_request_file_dir_job_unittest.cc
index e4f154ae7bcebaac88059f02d1b6ef4f178b0360..0f29d9097ba65a69206a2c51cf5ce881ba7be532 100644
--- a/net/url_request/url_request_file_dir_job_unittest.cc
+++ b/net/url_request/url_request_file_dir_job_unittest.cc
@@ -19,6 +19,7 @@
#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
#include "net/test/gtest_util.h"
+#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_test_util.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -115,7 +116,7 @@ TEST_F(URLRequestFileDirTest, ListCompletionOnNoPending) {
std::unique_ptr<URLRequest> request(context_.CreateRequest(
FilePathToFileURL(
directory.GetPath().AppendASCII("this_path_does_not_exist")),
- DEFAULT_PRIORITY, &delegate_));
+ DEFAULT_PRIORITY, &delegate_, TRAFFIC_ANNOTATION_FOR_TESTS));
request->Start();
ASSERT_TRUE(directory.Delete());
@@ -144,8 +145,9 @@ TEST_F(URLRequestFileDirTest, DirectoryWithASingleFileSync) {
TestJobFactory factory(directory.GetPath());
context_.set_job_factory(&factory);
- std::unique_ptr<URLRequest> request(context_.CreateRequest(
- FilePathToFileURL(path), DEFAULT_PRIORITY, &delegate_));
+ std::unique_ptr<URLRequest> request(
+ context_.CreateRequest(FilePathToFileURL(path), DEFAULT_PRIORITY,
+ &delegate_, TRAFFIC_ANNOTATION_FOR_TESTS));
request->Start();
EXPECT_TRUE(request->is_pending());
@@ -177,8 +179,9 @@ TEST_F(URLRequestFileDirTest, DirectoryWithASingleFileAsync) {
context_.set_job_factory(&factory);
TestDelegate delegate;
- std::unique_ptr<URLRequest> request(context_.CreateRequest(
- FilePathToFileURL(path), DEFAULT_PRIORITY, &delegate));
+ std::unique_ptr<URLRequest> request(
+ context_.CreateRequest(FilePathToFileURL(path), DEFAULT_PRIORITY,
+ &delegate, TRAFFIC_ANNOTATION_FOR_TESTS));
request->Start();
EXPECT_TRUE(request->is_pending());
@@ -209,8 +212,9 @@ TEST_F(URLRequestFileDirTest, DirectoryWithAFileAndSubdirectory) {
context_.set_job_factory(&factory);
TestDelegate delegate;
- std::unique_ptr<URLRequest> request(context_.CreateRequest(
- FilePathToFileURL(path), DEFAULT_PRIORITY, &delegate));
+ std::unique_ptr<URLRequest> request(
+ context_.CreateRequest(FilePathToFileURL(path), DEFAULT_PRIORITY,
+ &delegate, TRAFFIC_ANNOTATION_FOR_TESTS));
request->Start();
EXPECT_TRUE(request->is_pending());
@@ -236,7 +240,8 @@ TEST_F(URLRequestFileDirTest, EmptyDirectory) {
TestDelegate delegate;
std::unique_ptr<URLRequest> request(context_.CreateRequest(
- FilePathToFileURL(directory.GetPath()), DEFAULT_PRIORITY, &delegate));
+ FilePathToFileURL(directory.GetPath()), DEFAULT_PRIORITY, &delegate,
+ TRAFFIC_ANNOTATION_FOR_TESTS));
request->Start();
EXPECT_TRUE(request->is_pending());
« no previous file with comments | « net/url_request/url_request_context_builder_unittest.cc ('k') | net/url_request/url_request_file_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698