Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: net/url_request/url_request_simple_job_unittest.cc

Issue 2837543002: Test network annotation tags added to unittests in net/url_request. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_simple_job_unittest.cc
diff --git a/net/url_request/url_request_simple_job_unittest.cc b/net/url_request/url_request_simple_job_unittest.cc
index 73c4c56ba6b4fd94494f5df387d9f282ec472fe0..088b157e525845a458de5b80382df87d4c64f11f 100644
--- a/net/url_request/url_request_simple_job_unittest.cc
+++ b/net/url_request/url_request_simple_job_unittest.cc
@@ -18,6 +18,7 @@
#include "base/test/scoped_task_scheduler.h"
#include "net/base/request_priority.h"
#include "net/test/gtest_util.h"
+#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "net/url_request/url_request_job.h"
#include "net/url_request/url_request_job_factory.h"
#include "net/url_request/url_request_job_factory_impl.h"
@@ -118,8 +119,8 @@ class URLRequestSimpleJobTest : public ::testing::Test {
context_.set_job_factory(&job_factory_);
context_.Init();
- request_ =
- context_.CreateRequest(GURL("data:test"), DEFAULT_PRIORITY, &delegate_);
+ request_ = context_.CreateRequest(GURL("data:test"), DEFAULT_PRIORITY,
+ &delegate_, TRAFFIC_ANNOTATION_FOR_TESTS);
}
void StartRequest(const HttpRequestHeaders* headers) {
@@ -196,16 +197,16 @@ TEST_F(URLRequestSimpleJobTest, InvalidRangeRequest) {
}
TEST_F(URLRequestSimpleJobTest, EmptyDataRequest) {
- request_ =
- context_.CreateRequest(GURL("data:empty"), DEFAULT_PRIORITY, &delegate_);
+ request_ = context_.CreateRequest(GURL("data:empty"), DEFAULT_PRIORITY,
+ &delegate_, TRAFFIC_ANNOTATION_FOR_TESTS);
StartRequest(nullptr);
EXPECT_THAT(delegate_.request_status(), IsOk());
EXPECT_EQ("", delegate_.data_received());
}
TEST_F(URLRequestSimpleJobTest, CancelBeforeResponseStarts) {
- request_ =
- context_.CreateRequest(GURL("data:cancel"), DEFAULT_PRIORITY, &delegate_);
+ request_ = context_.CreateRequest(GURL("data:cancel"), DEFAULT_PRIORITY,
+ &delegate_, TRAFFIC_ANNOTATION_FOR_TESTS);
request_->Start();
request_->Cancel();
@@ -216,8 +217,9 @@ TEST_F(URLRequestSimpleJobTest, CancelBeforeResponseStarts) {
TEST_F(URLRequestSimpleJobTest, CancelAfterFirstReadStarted) {
CancelAfterFirstReadURLRequestDelegate cancel_delegate;
- request_ = context_.CreateRequest(GURL("data:cancel"), DEFAULT_PRIORITY,
- &cancel_delegate);
+ request_ =
+ context_.CreateRequest(GURL("data:cancel"), DEFAULT_PRIORITY,
+ &cancel_delegate, TRAFFIC_ANNOTATION_FOR_TESTS);
request_->Start();
cancel_delegate.WaitUntilHeadersReceived();
« no previous file with comments | « net/url_request/url_request_quic_unittest.cc ('k') | net/url_request/url_request_throttler_simulation_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698