Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(130)

Issue 2837523002: Add ASSERTs to WebFrameTest to ensure frame parameters are correct (Closed)

Created:
3 years, 3 months ago by sashab
Modified:
3 years, 3 months ago
Reviewers:
tkent, slangley
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ASSERTs to WebFrameTest to ensure frame parameters are correct Add ASSERTs to WebFrameTest to ensure frame parameters are correct in a few tests, and redesigned part of ContextLifetimeTestWebFrameClient to support correct WebFrameClient creation for child frames. This is pre-work to remove the redundant WebLocalFrame parmeters from didCreateScriptContext and willReleaseScriptContext. BUG=361765 Review-Url: https://codereview.chromium.org/2837523002 Cr-Commit-Position: refs/heads/master@{#467240} Committed: https://chromium.googlesource.com/chromium/src/+/ac3c4618a593af5860af38169befa3890e248b34

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -33 lines) Patch
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 9 chunks +83 lines, -33 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
sashab
3 years, 3 months ago (2017-04-21 02:43:11 UTC) #3
slangley
lgtm
3 years, 3 months ago (2017-04-21 02:47:02 UTC) #4
sashab
Not sure the best person to review this while dcheng@ is away. tkent@ wdyt?
3 years, 3 months ago (2017-04-21 02:48:21 UTC) #6
tkent
lgtm
3 years, 3 months ago (2017-04-21 02:56:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837523002/20001
3 years, 3 months ago (2017-04-26 04:00:51 UTC) #14
commit-bot: I haz the power
3 years, 3 months ago (2017-04-26 05:18:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ac3c4618a593af5860af38169bef...

Powered by Google App Engine
This is Rietveld 408576698