Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 2838503002: Remove redundant WebLocalFrame* parameter from WillReleaseScriptContext (Closed)

Created:
2 years, 6 months ago by sashab
Modified:
2 years, 6 months ago
Reviewers:
tkent, kinuko, slangley
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* parameter from WillReleaseScriptContext Remove redundant WebLocalFrame* parameter from WillReleaseScriptContext in WebFrameClient. BUG=361765 Review-Url: https://codereview.chromium.org/2838503002 Cr-Commit-Position: refs/heads/master@{#467259} Committed: https://chromium.googlesource.com/chromium/src/+/9e289b3dac38afcb47438b000622854a0560ff43

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M content/renderer/render_frame_impl.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (11 generated)
sashab
2 years, 6 months ago (2017-04-24 00:21:34 UTC) #3
slangley
lgtm
2 years, 6 months ago (2017-04-24 01:35:00 UTC) #7
sashab
tkent@ webkit, kinuko content, ty :)
2 years, 6 months ago (2017-04-26 02:15:56 UTC) #11
kinuko
lgtm
2 years, 6 months ago (2017-04-26 02:20:37 UTC) #12
tkent
lgtm
2 years, 6 months ago (2017-04-26 02:20:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2838503002/20001
2 years, 6 months ago (2017-04-26 05:26:26 UTC) #15
commit-bot: I haz the power
2 years, 6 months ago (2017-04-26 07:07:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9e289b3dac38afcb47438b000622...

Powered by Google App Engine
This is Rietveld 408576698