Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2830003002: Remove redundant WebLocalFrame* parameter from DidChangeScrollOffset (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
Reviewers:
slangley, kinuko, tkent
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* parameter from DidChangeScrollOffset Remove redundant WebLocalFrame* parameter from DidChangeScrollOffset in WebFrameClient. Also updated relevant tests in WebFrameTest. BUG=361765 Review-Url: https://codereview.chromium.org/2830003002 Cr-Commit-Position: refs/heads/master@{#467225} Committed: https://chromium.googlesource.com/chromium/src/+/ef13f14a203f0bdfe5f57e8cfa4d082320bfeb87

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M content/renderer/render_frame_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
sashab
3 years, 8 months ago (2017-04-20 06:53:43 UTC) #4
slangley
lgtm
3 years, 8 months ago (2017-04-21 00:52:44 UTC) #7
sashab
kinuko ptal at content tkent ptal at webkit ty!
3 years, 8 months ago (2017-04-21 00:54:23 UTC) #9
tkent
lgtm
3 years, 8 months ago (2017-04-21 00:58:10 UTC) #10
kinuko
lgtm
3 years, 8 months ago (2017-04-21 01:05:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830003002/20001
3 years, 8 months ago (2017-04-26 01:45:32 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 03:58:11 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ef13f14a203f0bdfe5f57e8cfa4d...

Powered by Google App Engine
This is Rietveld 408576698