Chromium Code Reviews
DescriptionReplace drainUntilIdle with a dispatch_barrier_sync for Breakpad tests
drainUntilIdle was a crutch because it didn't fully eliminate the race
condition between Breakpad setting its state on its own queue and the
tests.
This CL adds a test method to get the BreakpadController queue and
dispatches a barrier block on it to wait until the BreakpadController
updated its state.
Previously:
https://codereview.chromium.org/2760973002/
https://codereview.chromium.org/2775403003/
BUG=700839
R=baxley@chromium.org
CC=olivierrobin@chromium.or
Review-Url: https://codereview.chromium.org/2827313002
Cr-Commit-Position: refs/heads/master@{#466065}
(cherry picked from commit 5895ccc48d4395a1b5359a6ca8ca9eb654d4cd3d)
Review-Url: https://codereview.chromium.org/2837483003 .
Cr-Commit-Position: refs/branch-heads/3071@{#119}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/20d59625dac84ed76c03f45b49a1f3979e5f9be1
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||