Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2775403003: Wait for WWAN state to propagate to Breakpad in EG tests (Closed)

Created:
3 years, 8 months ago by lpromero
Modified:
3 years, 8 months ago
Reviewers:
Olivier, olivierrobin
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Wait for WWAN state to propagate to Breakpad in EG tests The issue is that SetWWANStateTo calls ultimately to an asynchronous method in Breakpad (-setUploadingEnabled:). So we need to wait for the propagation before asserting behaviors and state. BUG=700839 R=olivierrobin@google.com Review-Url: https://codereview.chromium.org/2775403003 Cr-Commit-Position: refs/heads/master@{#460095} Committed: https://chromium.googlesource.com/chromium/src/+/4e751ec73a63ac0600f1b3fa758a864cc29da52b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/browser/ui/settings/settings_egtest.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lpromero
3 years, 8 months ago (2017-03-28 13:30:03 UTC) #1
Olivier
lgtm
3 years, 8 months ago (2017-03-28 13:31:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775403003/1
3 years, 8 months ago (2017-03-28 14:13:22 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 14:20:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4e751ec73a63ac0600f1b3fa758a...

Powered by Google App Engine
This is Rietveld 408576698