Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2760973002:
Fix SettingsTestCase.testBreakpadReportingFirstLaunch on Official (Closed)
|
Created:
3 years, 9 months ago by lpromero Modified:
3 years, 8 months ago Reviewers:
Olivier CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix SettingsTestCase.testBreakpadReportingFirstLaunch on Official
Breakpad sets its state with dispatch_async:
https://cs.chromium.org/chromium/src/breakpad/src/client/ios/BreakpadController.mm?sq=package:chromium&dr&l=174
In EarlGrey tests, wait for the state to be consistent before
proceeding.
BUG=700839
R=olivierrobin@chromium.org
Review-Url: https://codereview.chromium.org/2760973002
Cr-Commit-Position: refs/heads/master@{#459474}
Committed: https://chromium.googlesource.com/chromium/src/+/502a0b3e580685f93a0319f433bcf150ddb6806d
Patch Set 1 #
Total comments: 3
Depends on Patchset: Messages
Total messages: 19 (11 generated)
The CQ bit was checked by lpromero@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by lpromero@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Kindly ping.
lgtm
https://codereview.chromium.org/2760973002/diff/1/ios/chrome/browser/ui/setti... File ios/chrome/browser/ui/settings/settings_egtest.mm (right): https://codereview.chromium.org/2760973002/diff/1/ios/chrome/browser/ui/setti... ios/chrome/browser/ui/settings/settings_egtest.mm:598: chrome_test_util::SetWWANStateTo(YES); Should we drainUntilIdle here too?
Thanks! https://codereview.chromium.org/2760973002/diff/1/ios/chrome/browser/ui/setti... File ios/chrome/browser/ui/settings/settings_egtest.mm (right): https://codereview.chromium.org/2760973002/diff/1/ios/chrome/browser/ui/setti... ios/chrome/browser/ui/settings/settings_egtest.mm:598: chrome_test_util::SetWWANStateTo(YES); On 2017/03/24 16:18:23, Olivier Robin wrote: > Should we drainUntilIdle here too? No because under the hood this is synchronous, unlike the Breakpad stuff I mention line 472.
The CQ bit was checked by lpromero@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1490377701159460, "parent_rev":
"adbac71e30fdf997eb5b543da155b08542f88c71", "commit_rev":
"502a0b3e580685f93a0319f433bcf150ddb6806d"}
Message was sent while issue was closed.
Description was changed from ========== Fix SettingsTestCase.testBreakpadReportingFirstLaunch on Official Breakpad sets its state with dispatch_async: https://cs.chromium.org/chromium/src/breakpad/src/client/ios/BreakpadControll... In EarlGrey tests, wait for the state to be consistent before proceeding. BUG=700839 R=olivierrobin@chromium.org ========== to ========== Fix SettingsTestCase.testBreakpadReportingFirstLaunch on Official Breakpad sets its state with dispatch_async: https://cs.chromium.org/chromium/src/breakpad/src/client/ios/BreakpadControll... In EarlGrey tests, wait for the state to be consistent before proceeding. BUG=700839 R=olivierrobin@chromium.org Review-Url: https://codereview.chromium.org/2760973002 Cr-Commit-Position: refs/heads/master@{#459474} Committed: https://chromium.googlesource.com/chromium/src/+/502a0b3e580685f93a0319f433bc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/502a0b3e580685f93a0319f433bc...
Message was sent while issue was closed.
https://codereview.chromium.org/2775403003/ https://codereview.chromium.org/2760973002/diff/1/ios/chrome/browser/ui/setti... File ios/chrome/browser/ui/settings/settings_egtest.mm (right): https://codereview.chromium.org/2760973002/diff/1/ios/chrome/browser/ui/setti... ios/chrome/browser/ui/settings/settings_egtest.mm:598: chrome_test_util::SetWWANStateTo(YES); On 2017/03/24 17:48:17, lpromero wrote: > On 2017/03/24 16:18:23, Olivier Robin wrote: > > Should we drainUntilIdle here too? > > No because under the hood this is synchronous, unlike the Breakpad stuff I > mention line 472. Ooops… Yes this is needed as SetWWANStateTo calls -connectionTypeChanged: which calls -setBreakpadUploadingEnabled: which calls SetUploadingEnabled which calls -setUploadingEnabled: which is the asynchronous one… Adding those. I tested that locally it fixes the 2 tests. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
