third_party/WebKit/Source/modules/indexeddb/IDBIndex.idl - Issue 2837373002: Indexed DB: Remove unnecessary defaults for optional args

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBIndex.idl

Issue 2837373002: Indexed DB: Remove unnecessary defaults for optional args (Closed)

Patch Set: rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBIndex.idl

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBIndex.idl b/third_party/WebKit/Source/modules/indexeddb/IDBIndex.idl

index 5e1bace34785b543fbbb0f8cde6332decdf54c5d..b7b57e3acb2e4f68a003d9b8c2b0d5e46bed4551 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBIndex.idl

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBIndex.idl

@@ -36,12 +36,10 @@

[NewObject, CallWith=ScriptState, RaisesException] IDBRequest get(any key);

[NewObject, CallWith=ScriptState, RaisesException] IDBRequest getKey(any key);

- // TODO(cmumford): 0xFFFFFFFF is not necessary. Remove once crbug.com/335871 is fixed.

- [NewObject, CallWith=ScriptState, RaisesException] IDBRequest getAll([Default=Undefined] optional any range,

- [EnforceRange] optional unsigned long maxCount = 0xFFFFFFFF);

- // TODO(cmumford): 0xFFFFFFFF is not necessary. Remove once crbug.com/335871 is fixed.

- [NewObject, CallWith=ScriptState, RaisesException] IDBRequest getAllKeys([Default=Undefined] optional any range,

- [EnforceRange] optional unsigned long maxCount = 0xFFFFFFFF);

+ [NewObject, CallWith=ScriptState, RaisesException] IDBRequest getAll([Default=Undefined] optional any query,

+ [EnforceRange] optional unsigned long count);

+ [NewObject, CallWith=ScriptState, RaisesException] IDBRequest getAllKeys([Default=Undefined] optional any query,

+ [EnforceRange] optional unsigned long count);

[NewObject, CallWith=ScriptState, RaisesException] IDBRequest count([Default=Undefined] optional any key);

[NewObject, CallWith=ScriptState, RaisesException] IDBRequest openCursor([Default=Undefined] optional any range,

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.idl » ('j') | no next file with comments »