Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 2837363003: 2. Remove HTMLParserScriptRunner's prefinalizer (Closed)

Created:
3 years, 3 months ago by hiroshige
Modified:
3 years, 3 months ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, kinuko+watch, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HTMLParserScriptRunner's prefinalizer We don't have to Dispose() PendingScripts, because: - If HTMLParserScriptRunner is watching for load of a PendingScript, then the PendingScript has a Member<HTMLParserScriptRunner> of |this|, and thus at prefinalization the PendingScript is also to be garbage collected. Dispose() is called by PendingScript's prefinalizer. - Otherwise, what matters in PendingScript::Dispose() is ScriptStreamer::Cancel() in ClassicPendingScript::DisposeInternal(). This CL might defer that ScriptStreamer::Cancel() to when ClassicPendingScript is prefinalized, but this shouldn't cause anything functionally wrong. BUG=715309 Review-Url: https://codereview.chromium.org/2837363003 Cr-Commit-Position: refs/heads/master@{#467224} Committed: https://chromium.googlesource.com/chromium/src/+/3d70ed2630a00fee3b5014b015ec765155885e54

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
kouhei (in TOK)
lgtm
3 years, 3 months ago (2017-04-26 00:21:41 UTC) #5
hiroshige
PTAL haraken@ and kouhei@ for Oilpan issues. sof@ (who touched related code when migrating from ...
3 years, 3 months ago (2017-04-26 00:35:01 UTC) #10
haraken
LGTM
3 years, 3 months ago (2017-04-26 01:02:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837363003/20001
3 years, 3 months ago (2017-04-26 03:12:17 UTC) #15
commit-bot: I haz the power
3 years, 3 months ago (2017-04-26 03:57:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3d70ed2630a00fee3b5014b015ec...

Powered by Google App Engine
This is Rietveld 408576698