Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(90)

Issue 2839033002: 3. Remove PendingScript's prefinalizer (Closed)

Created:
3 years, 3 months ago by hiroshige
Modified:
3 years, 3 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PendingScript's prefinalizer We don't have to clear |client_| and |element_| because they are Member<>, and also we can left other members of PendingScript as we can leave the object in a potentially corrupted state after prefinalization. Also, after https://codereview.chromium.org/2837363003/, PendingScript seems not touched during other prefinalizers. BUG=715309 Review-Url: https://codereview.chromium.org/2839033002 Cr-Commit-Position: refs/heads/master@{#467235} Committed: https://chromium.googlesource.com/chromium/src/+/00a279559130cd2818c66eaf047a77d39158858a

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
kouhei (in TOK)
lgtm
3 years, 3 months ago (2017-04-26 00:22:08 UTC) #5
hiroshige
PTAL haraken@ and kouhei@ for Oilpan issues. sof@ (who touched related code when migrating from ...
3 years, 3 months ago (2017-04-26 00:35:20 UTC) #9
haraken
LGTM
3 years, 3 months ago (2017-04-26 01:04:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2839033002/20001
3 years, 3 months ago (2017-04-26 04:44:59 UTC) #14
commit-bot: I haz the power
3 years, 3 months ago (2017-04-26 04:48:59 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/00a279559130cd2818c66eaf047a...

Powered by Google App Engine
This is Rietveld 408576698