Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.h

Issue 2837363003: 2. Remove HTMLParserScriptRunner's prefinalizer (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.h
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.h b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.h
index 8059a7ddd302ee82fc2c99b754d50d41ef493dd4..09a30e512fc679291e42764d53d40da6a85c0026 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.h
+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.h
@@ -55,7 +55,6 @@ class HTMLParserScriptRunner final
private PendingScriptClient {
WTF_MAKE_NONCOPYABLE(HTMLParserScriptRunner);
USING_GARBAGE_COLLECTED_MIXIN(HTMLParserScriptRunner);
- USING_PRE_FINALIZER(HTMLParserScriptRunner, Detach);
public:
static HTMLParserScriptRunner* Create(HTMLParserReentryPermit* reentry_permit,
@@ -65,8 +64,10 @@ class HTMLParserScriptRunner final
}
~HTMLParserScriptRunner();
- // Prepares this object to be destroyed. Invoked when the parser is detached,
- // or failing that, as a pre-finalizer.
+ // Invoked when the parser is detached.
+ //
+ // We don't need to call Detach() as a prefinalizer, because PendingScripts
+ // are Dispose()d in PendingScripts' prefinalizers.
void Detach();
// Processes the passed in script and any pending scripts if possible.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698