Chromium Code Reviews Chromium Code Reviews
Issue
2836433002:
Revert of Do not hide shadow underlay for max/fullscreen state even if the client disables the shad… (Closed)
DescriptionRevert of Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. (patchset #3 id:40001 of https://codereview.chromium.org/2820493004/ )
Reason for revert:
This change broke basic WM interaction of ARC and caused browser crash. https://crbug.com/713560
Original issue's description:
> Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow.
>
> During the state transition, ARC preserves windows being deleted,
> however the main window is deleted (thus, window frame is empty) which disables the shadow.
>
> BUG=711514
> TEST=covered by unit tests.
> manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
>
> Review-Url: https://codereview.chromium.org/2820493004
> Cr-Commit-Position: refs/heads/master@{#464819}
> Committed: https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f32943f29af15c3d8
TBR=reveman@chromium.org,oshima@chromium.org
BUG=713560
Review-Url: https://codereview.chromium.org/2827233002
Cr-Commit-Position: refs/heads/master@{#466063}
(cherry picked from commit b650cb773adbf72f3f731e0bc56e22d55c521391)
Review-Url: https://codereview.chromium.org/2836433002 .
Cr-Commit-Position: refs/branch-heads/3029@{#758}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/f053a5346cc243578179e26b0331f5e0f6fe4316
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||
