|
|
DescriptionDo not hide shadow underlay for max/fullscreen state even if the client disables the shadow.
During the state transition, ARC preserves windows being deleted,
however the main window is deleted (thus, window frame is empty) which disables the shadow.
BUG=711514
TEST=covered by unit tests.
manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
Review-Url: https://codereview.chromium.org/2820493004
Cr-Commit-Position: refs/heads/master@{#464819}
Committed: https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f32943f29af15c3d8
Patch Set 1 #Patch Set 2 : fix #
Total comments: 1
Patch Set 3 : renamed #
Messages
Total messages: 27 (20 generated)
Description was changed from ========== Do not delete shadow underlay for maximize state even if the client disables the shadow. During the state transition, ARC preserves windows being deleted, but the real window is deleted which disables the shadow. BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. ========== to ========== Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. During the state transition, ARC preserves windows being deleted, however the real window is deleted which disables the shadow. BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. ==========
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
oshima@chromium.org changed reviewers: + reveman@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. During the state transition, ARC preserves windows being deleted, however the real window is deleted which disables the shadow. BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. ========== to ========== Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. During the state transition, ARC preserves windows being deleted, however the real window is deleted (thus, window frame is empty) which disables the shadow. BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. ==========
Description was changed from ========== Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. During the state transition, ARC preserves windows being deleted, however the real window is deleted (thus, window frame is empty) which disables the shadow. BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. ========== to ========== Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. During the state transition, ARC preserves windows being deleted, however the main window is deleted (thus, window frame is empty) which disables the shadow. BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with nit https://codereview.chromium.org/2820493004/diff/20001/components/exo/shell_su... File components/exo/shell_surface.cc (right): https://codereview.chromium.org/2820493004/diff/20001/components/exo/shell_su... components/exo/shell_surface.cc:1564: bool black_backdrop_enabled = nit: black_background_enabled or shadow_underlay_enabled as that's how we refer to this below
On 2017/04/14 20:18:44, reveman wrote: > lgtm with nit > > https://codereview.chromium.org/2820493004/diff/20001/components/exo/shell_su... > File components/exo/shell_surface.cc (right): > > https://codereview.chromium.org/2820493004/diff/20001/components/exo/shell_su... > components/exo/shell_surface.cc:1564: bool black_backdrop_enabled = > nit: black_background_enabled or shadow_underlay_enabled as that's how we refer > to this below renamed to black_background_enabled
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by oshima@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org Link to the patchset: https://codereview.chromium.org/2820493004/#ps40001 (title: "renamed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492211523462960, "parent_rev": "5e01790eab3cada300a30125432a5c90c6ef2867", "commit_rev": "ae72f92d7caba6d32ba2a11f32943f29af15c3d8"}
Message was sent while issue was closed.
Description was changed from ========== Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. During the state transition, ARC preserves windows being deleted, however the main window is deleted (thus, window frame is empty) which disables the shadow. BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. ========== to ========== Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. During the state transition, ARC preserves windows being deleted, however the main window is deleted (thus, window frame is empty) which disables the shadow. BUG=711514 TEST=covered by unit tests. manual. Instal & start "Clash Royal", then F4 to toggle fullscreen. Review-Url: https://codereview.chromium.org/2820493004 Cr-Commit-Position: refs/heads/master@{#464819} Committed: https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f3294... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f3294...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2827233002/ by nya@chromium.org. The reason for reverting is: This change broke basic WM interaction of ARC and caused browser crash. https://crbug.com/713560. |